Use environment variables in config files #60 #80
Conversation
|
Junis are meant to be atomic. So you build tests like testBooleanVar teststringVar testIntegerVar testDataPipeFormat testOutputPipexxxx testDataPipeArrayFormat etc etc...go as many cases as you can think of, and combinations testBooleanStringxxxxx the tests also need to address the specific issue - values of pipe properties tests should also be there for malformed system var like and tests when something is referenced in json but not configured in env variable also need to be there. |
|
Also checkin comments need to be better - right now there are three commits with Use environment variables in config files. You can reference the issue in all commits, but the commit has to specify what is being changed too. |
|
The newly added testcases cover the above suggestions and other units/fragments of the the code changes. I tried to avoid redundant and out of scope scenarios. |
| @@ -54,7 +92,8 @@ public void testCreateArgsMissingMatchFile() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void testCreateArgsMissingDelimiterFile() { | |||
There was a problem hiding this comment.
remove these tests which are getting ignored
| matcher.appendReplacement(buffer, replacement != null ? Matcher.quoteReplacement(replacement) : "null"); | ||
| } | ||
| else { | ||
| LOG.warn("The environment variable for {" + matcher.group(1) + "} is not set"); |
There was a problem hiding this comment.
should we throw an exception here ?
There was a problem hiding this comment.
Added Exception.
|
Made changes as per comments and the discussion |
|
|
||
| fail("Exception was expected for blank value for an environment variable"); | ||
| } catch (IOException | ZinggClientException e) { | ||
| System.out.println("Expected exception received due to blank value for an environment variable"); |
|
Made changes to add Logger in Tests; Added message for substituted environment variables as well. |
Feature to allow user to pass environment variables for the Zingg configuration values #60