Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing OIDC documentation to OpenAPI #4013

Merged
merged 4 commits into from
Feb 27, 2025

Conversation

balhar-jakub
Copy link
Member

Description

The OIDC validate documentation was missing in 2.18 OpenAPI for Gateway. This PR adds the documentation that is now in V3.

Linked to #3885

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@balhar-jakub balhar-jakub self-assigned this Feb 26, 2025
Copy link
Contributor

@pj892031 pj892031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even I don't know why we accept serviceId and the ignore it, the doc is correct, serviceId is not used...

@balhar-jakub balhar-jakub merged commit d60d23d into v2.x.x Feb 27, 2025
31 checks passed
@balhar-jakub balhar-jakub deleted the apiml/GH3885/add-oidc-openapi branch February 27, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants