Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Status Screen Conversion To Hooks #4445

Closed
wants to merge 8 commits into from
Closed

User Status Screen Conversion To Hooks #4445

wants to merge 8 commits into from

Conversation

karanb1
Copy link

@karanb1 karanb1 commented Jan 29, 2021

This is the PR in the series that began with #4428..
It converts the user state class based component into hooks based component. I plan to further migrate more components to React navigation v5 standards, hook based lifecycle methods and redux hooks standards.

@karanb1 karanb1 changed the title User Screen Conversion To Hooks User Status Screen Conversion To Hooks Jan 29, 2021
@karanb1
Copy link
Author

karanb1 commented Jan 29, 2021

As this is my first contribution in this project, I had a few problems with ES lint configurations which I resolved eventually. @chrisbobbe please can you review this and guide me with necessary changes(if required).

@abhi0504
Copy link
Contributor

@karanb1 I suggest you should squash all your commits into one single commit also there are some branch conflicts you should also resolve them.
Please do format your commit message according to our commit-message style; there should be a properly formatted summary line and also a message body.
Also Zulip/Zulip-Mobile uses rebasing instead of merging branch you can go through these guidelines

@karanb1
Copy link
Author

karanb1 commented Jan 29, 2021

Thank you @abhi0504 for the suggestion. I will close this PR and create a new pull request according to the links you provided.

@karanb1 karanb1 closed this Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants