-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
analog_loop tests update for STM32 #3024
Conversation
@@ -187,12 +189,6 @@ | |||
"dependencies": [MBED_LIBRARIES, TEST_MBED_LIB], | |||
"automated": True, | |||
"peripherals": ["analog_loop"], | |||
"mcu": ["LPC1768", "LPC2368", "LPC2460", "KL25Z", "K64F", "K66F", "K22F", "LPC4088", "LPC1549", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking we probably don't want to remove the non-ST boards from this list, as the other boards still require some customization of the pins. Would you mind adding the non-ST boards back to this list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I can...
but as there is a check if analog in and out are supported or not in the test,
and test can not be executed while "peripherals" parameter is not set,
I ddidn't see any risk to remove the MCU list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not so much that they wouldn't have analog in or out supported, its that the pin names used for the analog loop are only defined for the targets in the mcu
list. It would lead to a build error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mcu list is back :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@c1728p9 mbed 2 bot run please |
@mbed-bot: TEST HOST_OSES=ALL |
[Build 1060] |
Test results OK |
Description
Make analog_loop OS2 tests available for all STM32 targets
Status
READY
Tests OK