Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace CMSIS flash driver by SDK flash driver #4485

Merged
merged 5 commits into from
Jul 10, 2017
Merged

Replace CMSIS flash driver by SDK flash driver #4485

merged 5 commits into from
Jul 10, 2017

Conversation

kegilbert
Copy link
Contributor

Rebase against master for: #4066

Smaller chunk of the Workshop branch additions: #4412

Feel free to add in however else should be a reviewer @c1728p9

@sg-
Copy link
Contributor

sg- commented Jun 7, 2017

I recall this failure and think there is another associated commit about target naming or directory or similar. https://travis-ci.org/ARMmbed/mbed-os/builds/240173808#L1310

@kegilbert
Copy link
Contributor Author

Thanks for the info @sg-!

@kegilbert
Copy link
Contributor Author

/morph test

@mbed-bot
Copy link

mbed-bot commented Jun 7, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 477

Build failed!

@kegilbert kegilbert force-pushed the f429_sdk_flash_driver-rebase branch from 977e25b to 5db6e4f Compare June 7, 2017 23:36
@kegilbert
Copy link
Contributor Author

/morph test

@mbed-bot
Copy link

mbed-bot commented Jun 8, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 484

Example Build failed!

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 8, 2017 •
edited
Loading

mbed-os-example-mesh-minimal NUCLEO_F429ZI IAR - this example fails to build . Seems relevant (but only for IAR though).

@kegilbert Can you test that one please?

@kegilbert
Copy link
Contributor Author

Strange, I was able to build that example locally with IAR and this branch...I wasn't able to get any information from the CI as to why that example failed other than:

Compiling mbed-os-example-mesh-minimal for NUCLEO_F429ZI, IAR
20:50:39 [ERROR] 
20:50:39 [mbed] ERROR: "c:\mj\workspace\bm_wrap\513\.env\scripts\python.exe" returned error code 1.
20:50:39 [mbed] ERROR: Command "c:\mj\workspace\bm_wrap\513\.env\scripts\python.exe -u C:\mj\workspace\bm_wrap\513\examples\mbed-os-example-mesh-minimal\mbed-os\tools\make.py -t IAR -m NUCLEO_F429ZI --source . --build .\BUILD\NUCLEO_F429ZI\IAR --silent" in "C:\mj\workspace\bm_wrap\513\examples\mbed-os-example-mesh-minimal"

@kegilbert
Copy link
Contributor Author

Running again just to be sure
/morph test

@mbed-bot
Copy link

mbed-bot commented Jun 8, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 505

Test failed!

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2017

Can you test locally? Seems like all these devices changed in this patch result in error for flashIAP tests

@kegilbert
Copy link
Contributor Author

That was our next step, wasn't able to last night but will check ASAP.

@c1728p9
Copy link
Contributor

c1728p9 commented Jun 10, 2017

Added a new commit to fix the flash test errors. @adustm, NVIC_SetVector is getting called very early in the boot sequence (SystemInit) and trying to write the new vector to flash. This is probably something that should be fixed. I added a workaround in this patch to clear the error flags before flashing.

CC: @bulislaw

@ARMmbed ARMmbed deleted a comment from mbed-bot Jun 10, 2017
@ARMmbed ARMmbed deleted a comment from c1728p9 Jun 10, 2017
@sg-
Copy link
Contributor

sg- commented Jun 10, 2017

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 530

Example Build failed!

@c1728p9
Copy link
Contributor

c1728p9 commented Jun 11, 2017

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 533

Example Build failed!

@sg-
Copy link
Contributor

sg- commented Jun 11, 2017

/morph export-build

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 55

All exports and builds passed!

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 12, 2017

@studavekar Can we get a nice error for example errors, taken from #4485 (comment), there's one failure, and the console shows this:

23:03:25 Compiling mbed-os-example-mesh-minimal for NUCLEO_F429ZI, IAR
23:03:28 [ERROR]

@studavekar
Copy link
Contributor

studavekar commented Jun 12, 2017 •
edited
Loading

we can take out --silent argument @ here this may help provide pointer with failure.

@bridadan does that sound ok or any other suggestion.

@bridadan
Copy link
Contributor

@studavekar Sounds good! I made a PR for it this morning here: #4530

@RobMeades RobMeades mentioned this pull request Jun 13, 2017
Closed
@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 29, 2017

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 686

Example Build failed!

@theotherjimmy
Copy link
Contributor

@kegilbert That's a real example build failure. Could you take a look?

@kegilbert
Copy link
Contributor Author

Looking into it now, I remember this cropping up before.

@kegilbert
Copy link
Contributor Author

Still not able to reproduce locally, looks like it's a tooling error from the error output:

06:33:32 Compile [ 0.2%]: cmain.S
06:33:32 [DEBUG] Compile: C:\Program Files (x86)\IAR Systems\Embedded Workbench 7.5\arm\bin\iasmarm --cpu Cortex-M4F -DTRANSACTION_QUEUE_SIZE_SPI=2 -D__CORTEX_M4 -DUSB_STM_HAL -DARM_MATH_CM4 -D__FPU_PRESENT=1 -DUSBHOST_OTHER -D__MBED_CMSIS_RTOS_CM -D__CMSIS_RTOS -f .\BUILD\NUCLEO_F429ZI\IAR.includes_6ff26e09053f6aa1fffee0baae576859.txt -o .\BUILD\NUCLEO_F429ZI\IAR\mbed-os\cmsis\TOOLCHAIN_IAR\cmain.o .\mbed-os\cmsis\TOOLCHAIN_IAR\cmain.S
06:33:32 [DEBUG] Return: -1073740940
06:33:32 Traceback (most recent call last):
06:33:32 File "C:\mj\workspace\bm_wrap\735\examples\mbed-os-example-mesh-minimal\mbed-os\tools\make.py", line 280, in
06:33:32 toolchain))
06:33:32 File "C:\mj\workspace\bm_wrap\735\examples\mbed-os-example-mesh-minimal\mbed-os\tools\build_api.py", line 536, in build_project
06:33:33 objects = toolchain.compile_sources(resources, resources.inc_dirs)
06:33:33 File "C:\mj\workspace\bm_wrap\735\examples\mbed-os-example-mesh-minimal\mbed-os\tools\toolchains_init_.py", line 906, in compile_sources
06:33:33 return self.compile_queue(queue, objects)
> 06:33:33 File "C:\mj\workspace\bm_wrap\735\examples\mbed-os-example-mesh-minimal\mbed-os\tools\toolchains_init_.py", line 969, in compile_queue
06:33:33 raise ToolException(err)
06:33:33 ToolException
06:33:33 [mbed] Working path "C:\mj\workspace\bm_wrap\735\examples\mbed-os-example-mesh-minimal" (program)
06:33:33 [mbed] Auto-installing missing Python modules...
06:33:33 [mbed] Exec "c:\mj\workspace\bm_wrap\735.env\scripts\python.exe -u C:\mj\workspace\bm_wrap\735\examples\mbed-os-example-mesh-minimal\mbed-os\tools\make.py -t IAR -m NUCLEO_F429ZI --source . --build .\BUILD\NUCLEO_F429ZI\IAR -v" in C:\mj\workspace\bm_wrap\735\examples\mbed-os-example-mesh-minimal
06:33:33 [mbed] ERROR: "c:\mj\workspace\bm_wrap\735.env\scripts\python.exe" returned error code 1.
06:33:33 [mbed] ERROR: Command "c:\mj\workspace\bm_wrap\735.env\scripts\python.exe -u C:\mj\workspace\bm_wrap\735\examples\mbed-os-example-mesh-minimal\mbed-os\tools\make.py -t IAR -m NUCLEO_F429ZI --source . --build .\BUILD\NUCLEO_F429ZI\IAR -v" in "C:\mj\workspace\bm_wrap\735\examples\mbed-os-example-mesh-minimal"
06:33:33 ---

@theotherjimmy
Copy link
Contributor

theotherjimmy commented Jun 29, 2017 •
edited
Loading

@kegilbert Just because you get a traceback, does not mean it's a tooling error. You always get a traceback with -v, which is what the CI runs these commands with. If you look at the actual error, you can see that it's the IAR assembler returning -1073740940, without any further output.

adustm added 5 commits June 29, 2017 14:24
@adustm @kegilbert
Allow UBLOX to use SDK flash driver
565c3c1
@adustm @kegilbert
Rebase: ARMmbed@0d1c6c2
64e902e 
This commit completely rewrote flash_api.c in a few places so kicked out changes from Master and accepted the branch changes.

F429 + F439 : changes after code review
GetSector has been rewritten
@adustm @kegilbert
Rebase of: ARMmbed@dfd0cf6
e7fb5b4 
fix STM32F439 flash HAL
@adustm @kegilbert
Rebase of: ARMmbed@cb3907e
4860e6a 
typo in flash_s struct
@adustm @kegilbert
Replase CMSIS flash driver by SDK flash driver
90bc8ca
@kegilbert kegilbert force-pushed the f429_sdk_flash_driver-rebase branch from 01bc989 to 90bc8ca Compare June 29, 2017 19:25
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 4, 2017

@kegilbert Have you been able to reproduce. I can see here rebase, is it resolved and we can review/run CI again?

@kegilbert
Copy link
Contributor Author

We are not able to reproduce locally or in the CI environment manually when I last tested that. We've been looking into why it seems to only be happening on CI runs @0xc0170 .

@kegilbert
Copy link
Contributor Author

The IAR version was updated on the CI machines, rerunning morph test to check if that resolved this issue.

/morph test

@mbed-bot
Copy link

mbed-bot commented Jul 5, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 734

All builds and test passed!

@kegilbert
Copy link
Contributor Author

@0xc0170 Should be good to go!

@theotherjimmy theotherjimmy merged commit 3d86959 into ARMmbed:master Jul 10, 2017
@andreaslarssonublox andreaslarssonublox mentioned this pull request Jul 12, 2017
Merged
@adbridge
Copy link
Contributor

adbridge commented Jul 14, 2017 •
edited
Loading

This commit:
e7fb5b4

Still has


<<<<<<< HEAD
...
...

=======

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 14, 2017

@kegilbert Please be careful with rebase, and always review commit by commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@c1728p9 c1728p9 c1728p9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@kegilbert @sg- @mbed-bot @0xc0170 @c1728p9 @studavekar @bridadan @adbridge @theotherjimmy @adustm