Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Try] Move Subscriber management: move to wp-admin from Calypso/Jetpack Cloud #42033

Draft
wants to merge 8 commits into
base: trunk
Choose a base branch
from

Conversation

jorgefilipecosta
Copy link
Member

This is PR not intended to be merged moving subscriber management from calypso/jetpack cloud to wp-admin.
The idea is to iterate on something end-to-end here. But merge things step by step.
This is the intended merge plan:

  • Boilerplate PR adding a new subscribers section, and the infrastructure to build a react page with dataviews under that page. The page will be under a feature flag.
  • Initial backend PR expanding the REST endpoints to accomplish our needs.
  • Start moving the UI implementation, without actions (multiple PR's in parallel).
  • Implement the actions.
  • Deal with complex used cases where calypso/wordpress.com is still required namely migrations of subscribers between different wordpress.com/jetpack sites, substack import, and CSV export.

Testing instructions:

Open jetpack go to "New subscribers" page, currently it should be possible to see a subscribers page similar to this:
Screenshot 2025-02-25 at 17 37 39

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests [Package] Subscribers labels Feb 25, 2025
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • 🔴 Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:

## Does this pull request change what data or activity we track or use?

My PR adds *x* and *y*.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Feb 25, 2025
@jorgefilipecosta jorgefilipecosta marked this pull request as draft February 26, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Subscribers [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant