Add subscribers in wp-admin starting page #42066
Conversation
jorgefilipecosta
added
[Feature] Subscriptions
github-actions
bot
added
the
[Plugin] Jetpack
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
github-actions
bot
added
the
[Status] Needs Author Reply
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
jorgefilipecosta
changed the title
Code Coverage SummaryCoverage changed in 6 files. Only the first 5 are listed here.
3 files are newly checked for coverage.
|
There was a problem hiding this comment.
👋 Quick drive-by to ask about the package name. If the package eventually comes to include more subscription-related features, what do you think about naming it "subscriptions"?
If it will only include the dashboard, should it be named "subscribers-dashboard"?
|
I was not successful in getting this to work. I think maybe I wasn't setting it up correctly. So I can't comment yet on the functionality of this PR. One question I do have is if this is the best place to put the subscriber stuff. I ask because I think we have a few other pieces for the Newsletter and subscriptions that exist in different places. For example we started building a widget that exists inside subscription modules directly. I am not super knowledgable about the architecture of Jetpack so I can't say for sure your decision is not ideal. As I mentioned this is just a question with some additional context. Thanks again for all this work. 💯 |
github-actions
bot
added
[Feature] Masterbar
jorgefilipecosta
force-pushed
the
add/subscribers-in-wp-admin-page
branch
from
4fea861 to
eec83ba
Compare
jorgefilipecosta
force-pushed
the
add/subscribers-in-wp-admin-page
branch
from
c8b3ab0 to
77828d6
Compare
Extracted from #42033.
This PR replaces the subscriber's link to Jetpack Cloud with a starting page for subscribers rendered with React.
The idea is to make things easier to review. This PR just contains what is required to have a menu item render a page with react.
The replacement of the external link with the new wp-admin-based page just happens when the jetpack_wp_admin_subscriber_management_enabled feature flag is active.
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Build the jetpack plugin to verify we keep exactly the current behavior of linking to the jetpack cloud when accessing subscribers as is.
Enabeed the jetpack_wp_admin_subscriber_management_enabled experiment by adding this code snippet:
add_filter( 'jetpack_wp_admin_subscriber_management_enabled', '__return_true' );Verify subscribers now render a page saying "Hello world!" instead of a link to the jetpack cloud.