Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(homepage-posts): change copy for deduplication block option #1578

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

miguelpeixe
Copy link
Member

@miguelpeixe miguelpeixe commented Nov 3, 2023

All Submissions:

Changes proposed in this Pull Request:

Changes the copy and reverse the toggle for the deduplication logic toggle on the Homepage Posts block (first introduced in #1543):

Before After
image image

How to test the changes in this Pull Request:

  1. Draft a new page and add 3 Homepage Posts block
  2. On the 2nd block, toggle "Allow duplicate posts" on and confirm it renders the contents from the first block and the 3rd block renders the content that was previously being rendered in the 2nd block
  3. Save, visit the page and confirm the same posts also render in the frontend

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe self-assigned this Nov 3, 2023
@miguelpeixe miguelpeixe requested a review from a team as a code owner November 3, 2023 14:49
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more intuitive!

@miguelpeixe miguelpeixe merged commit dff89a0 into master Nov 3, 2023
@miguelpeixe miguelpeixe deleted the fix/homepage-posts-deduplication-option-copy branch November 3, 2023 15:51
matticbot pushed a commit that referenced this pull request Nov 3, 2023
# [2.1.0-alpha.2](v2.1.0-alpha.1...v2.1.0-alpha.2) (2023-11-03)

### Bug Fixes

* **homepage-posts:** change copy for deduplication block option ([#1578](#1578)) ([dff89a0](dff89a0))
* **modal-checkout:** add id attributes to hidden inputs ([90f077c](90f077c))

### Features

* expose is_modal_checkout method ([4315730](4315730))
* **modal-checkout:** dequeue WC styles ([#1572](#1572)) ([9aa0039](9aa0039))
* **modal-checkout:** handle non-redirect-based flow (e.g. Apple Pay) ([#1573](#1573)) ([671b551](671b551))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.1.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Nov 13, 2023
# [2.1.0](v2.0.0...v2.1.0) (2023-11-13)

### Bug Fixes

* **homepage-posts:** change copy for deduplication block option ([#1578](#1578)) ([dff89a0](dff89a0))
* **modal-checkout:** add id attributes to hidden inputs ([90f077c](90f077c))
* **modal-checkout:** place order button width ([9b1b04e](9b1b04e)), closes [#1572](#1572) [#1586](#1586)

### Features

* **donate-block:** changes to button-after-success  ([#1571](#1571)) ([ac1c6a6](ac1c6a6))
* expose is_modal_checkout method ([4315730](4315730))
* **modal-checkout:** dequeue WC styles ([#1572](#1572)) ([9aa0039](9aa0039))
* **modal-checkout:** handle non-redirect-based flow (e.g. Apple Pay) ([#1573](#1573)) ([671b551](671b551))
* **modal-checkout:** update "place order" text to "donate now" ([#1591](#1591)) ([63fc202](63fc202))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants