Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal-checkout): place order button width #1586

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Fixes a regression introduced by #1572

⚠️ The regression is part of the latest alpha release, so this change should also be merged into alpha.

How to test the changes in this Pull Request:

  1. On master, trigger the modal checkout for a one-time donation
  2. Observe the "Place order" button at the second step is not 100% wide
  3. Switch to this branch, observe it is

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek requested a review from a team as a code owner November 7, 2023 09:56
@adekbadek adekbadek merged commit b48efcb into master Nov 8, 2023
@adekbadek adekbadek deleted the fix/place-order-button-width branch November 8, 2023 08:58
adekbadek added a commit that referenced this pull request Nov 8, 2023
Fixes regression introduced by #1572

#1586 as an alpha-hotfix
matticbot pushed a commit that referenced this pull request Nov 8, 2023
# [2.1.0-alpha.3](v2.1.0-alpha.2...v2.1.0-alpha.3) (2023-11-08)

### Bug Fixes

* **modal-checkout:** place order button width ([9b1b04e](9b1b04e)), closes [#1572](#1572) [#1586](#1586)
matticbot pushed a commit that referenced this pull request Nov 13, 2023
# [2.1.0](v2.0.0...v2.1.0) (2023-11-13)

### Bug Fixes

* **homepage-posts:** change copy for deduplication block option ([#1578](#1578)) ([dff89a0](dff89a0))
* **modal-checkout:** add id attributes to hidden inputs ([90f077c](90f077c))
* **modal-checkout:** place order button width ([9b1b04e](9b1b04e)), closes [#1572](#1572) [#1586](#1586)

### Features

* **donate-block:** changes to button-after-success  ([#1571](#1571)) ([ac1c6a6](ac1c6a6))
* expose is_modal_checkout method ([4315730](4315730))
* **modal-checkout:** dequeue WC styles ([#1572](#1572)) ([9aa0039](9aa0039))
* **modal-checkout:** handle non-redirect-based flow (e.g. Apple Pay) ([#1573](#1573)) ([671b551](671b551))
* **modal-checkout:** update "place order" text to "donate now" ([#1591](#1591)) ([63fc202](63fc202))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.2.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants