Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to dashboard after onboarding complete #908

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Slipped through the cracks in #892

How to test the changes in this Pull Request:

  1. Visit the onboarding, design step (/wp-admin/admin.php?page=newspack-setup-wizard#/design)
  2. Click "Finish"
  3. Observe being redirected to the plugin dashboard

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Mar 17, 2021
@adekbadek adekbadek requested review from jeffersonrabb and dkoo March 17, 2021 09:20
@adekbadek adekbadek changed the title Redirect to dashboard after onboardicomplete Redirect to dashboard after onboarding complete Mar 17, 2021
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After clicking "Finish", I get redirected to a blank page with the URL /wp-admin/admin.php?page=newspack-setup-wizard#/undefined and am only redirected after a few seconds.

@adekbadek
Copy link
Member Author

Whoops, fixed in 1fb83a6

@adekbadek adekbadek requested a review from dkoo March 18, 2021 09:31
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now!

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 18, 2021
@adekbadek adekbadek merged commit 5624822 into master Mar 19, 2021
@adekbadek adekbadek deleted the add/onboarding-design-step-redirect branch March 19, 2021 17:05
matticbot pushed a commit that referenced this pull request Mar 23, 2021
# [1.34.0-alpha.1](v1.33.2...v1.34.0-alpha.1) (2021-03-23)

### Bug Fixes

* apply correct color to jetpack logo ([#910](#910)) ([686362c](686362c))
* redirect after setup complete ([#908](#908)) ([5624822](5624822))
* starter content issues ([#905](#905)) ([6cbc40d](6cbc40d)), closes [#899](#899) [#904](#904) [#903](#903)

### Features

* leaner GA config ([#914](#914)) ([81cdff6](81cdff6)), closes [#911](#911)
* remove woocommerce-one-page-checkout from supported plugins list  ([#913](#913)) ([7fa2e31](7fa2e31))
* update welcome wizard card footer ([#909](#909)) ([134a0e9](134a0e9))
* **setup:** design step ([#892](#892)) ([254f08b](254f08b))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.34.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Mar 24, 2021
# [1.34.0](v1.33.2...v1.34.0) (2021-03-24)

### Bug Fixes

* apply correct color to jetpack logo ([#910](#910)) ([686362c](686362c))
* redirect after setup complete ([#908](#908)) ([5624822](5624822))
* starter content issues ([#905](#905)) ([6cbc40d](6cbc40d)), closes [#899](#899) [#904](#904) [#903](#903)

### Features

* custom placements ([#898](#898)) ([2cadb45](2cadb45))
* leaner GA config ([#914](#914)) ([81cdff6](81cdff6)), closes [#911](#911)
* remove woocommerce-one-page-checkout from supported plugins list  ([#913](#913)) ([7fa2e31](7fa2e31))
* update welcome wizard card footer ([#909](#909)) ([134a0e9](134a0e9))
* **setup:** design step ([#892](#892)) ([254f08b](254f08b))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.34.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants