Leaner GA config #914
Merged
Leaner GA config #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Threw: Element 'phpunit', attribute 'syntaxCheck': The attribute 'syntaxCheck' is not allowed.
adekbadek
added
the
[Status] Needs Review
6 tasks
dkoo
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
Confirmed that these changes and Automattic/newspack-popups#497 cut the payload size significantly (by more than half on my test site with 12 active prompts). I can respond again after I confirm I can see the analytics being reported in the dashboard.
github-actions
bot
added
[Status] Approved
6 tasks
matticbot
pushed a commit
that referenced
this pull request
Mar 23, 2021
# [1.34.0-alpha.1](v1.33.2...v1.34.0-alpha.1) (2021-03-23) ### Bug Fixes * apply correct color to jetpack logo ([#910](#910)) ([686362c](686362c)) * redirect after setup complete ([#908](#908)) ([5624822](5624822)) * starter content issues ([#905](#905)) ([6cbc40d](6cbc40d)), closes [#899](#899) [#904](#904) [#903](#903) ### Features * leaner GA config ([#914](#914)) ([81cdff6](81cdff6)), closes [#911](#911) * remove woocommerce-one-page-checkout from supported plugins list ([#913](#913)) ([7fa2e31](7fa2e31)) * update welcome wizard card footer ([#909](#909)) ([134a0e9](134a0e9)) * **setup:** design step ([#892](#892)) ([254f08b](254f08b))
|
🎉 This PR is included in version 1.34.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Mar 24, 2021
# [1.34.0](v1.33.2...v1.34.0) (2021-03-24) ### Bug Fixes * apply correct color to jetpack logo ([#910](#910)) ([686362c](686362c)) * redirect after setup complete ([#908](#908)) ([5624822](5624822)) * starter content issues ([#905](#905)) ([6cbc40d](6cbc40d)), closes [#899](#899) [#904](#904) [#903](#903) ### Features * custom placements ([#898](#898)) ([2cadb45](2cadb45)) * leaner GA config ([#914](#914)) ([81cdff6](81cdff6)), closes [#911](#911) * remove woocommerce-one-page-checkout from supported plugins list ([#913](#913)) ([7fa2e31](7fa2e31)) * update welcome wizard card footer ([#909](#909)) ([134a0e9](134a0e9)) * **setup:** design step ([#892](#892)) ([254f08b](254f08b))
|
🎉 This PR is included in version 1.34.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Mar 29, 2021
adekbadek
added a commit
that referenced
this pull request
Apr 28, 2021
To avoid gtag vendor config rewriter payload size limitation ampproject/amphtml#32911 Related to #914
adekbadek
added a commit
that referenced
this pull request
Apr 28, 2021
To avoid gtag vendor config rewriter payload size limitation ampproject/amphtml#32911 Related to #914
adekbadek
added a commit
that referenced
this pull request
Apr 29, 2021
To avoid gtag vendor config rewriter payload size limitation ampproject/amphtml#32911 Related to #914
matticbot
pushed a commit
that referenced
this pull request
May 4, 2021
# [1.38.0-alpha.1](v1.37.0...v1.38.0-alpha.1) (2021-05-04) ### Bug Fixes * use guest authors in Slack preview when needed ([#947](#947)) ([e42680e](e42680e)) ### Features * batch amp-analytics events ([481dc97](481dc97)), closes [#914](#914) * integrate Newspack Scheduled Post Checker into main plugin ([#940](#940)) ([c6adc1b](c6adc1b))
matticbot
pushed a commit
that referenced
this pull request
May 4, 2021
# [1.38.0](v1.37.0...v1.38.0) (2021-05-04) ### Bug Fixes * use guest authors in Slack preview when needed ([#947](#947)) ([e42680e](e42680e)) ### Features * batch amp-analytics events ([481dc97](481dc97)), closes [#914](#914) * integrate Newspack Scheduled Post Checker into main plugin ([#940](#940)) ([c6adc1b](c6adc1b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes #911.
How to test the changes in this Pull Request:
master, concoct a big GA config by enabling NTG events, adding some custom events, and then making it so a ton of prompts is included on a page. You can also inflate the config size by setting a super long title on one of the prompts.https://www.googletagmanager.com/gtag/ampshould fail, triggering aError rewriting configurationerror. Observe the GA events triggered by prompts being loaded, seen, and dismissed, are not sent (query network requests withcollect)add/leaner-ga-configonnewspack-popupsOther information: