-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InMemory Cache Provider #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Theres nothing fancy about this, I've added the ability to use Mocale without SQL Caching. This is a very basic app lifetime cache, but should do the trick!
Added tests for the in mem cache class aswell as the app builder. This is the first foray into an integration style test to make sure the logic in the app builder is sound, so far so good I'll get the rest tested!
The main solution was struggling, I've fixed it now
The dotnet cli really wants to miss whats right infront of its eyes!
Minimum allowed coverage is Generated by 🐒 cobertura-action against df9ed70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Mocale HAS to be used with the SQLite cache provider unless you roll your own caching solution. I've finally implemented a very basic in memory cache system so when external localizations are fetched they'll stick in memory for the lifetime of the application.
This has the downside of everytime you run the app it needs to call out to refresh the localizations however it means people using local cache only can have mocale run without the need to persist any data!
This PR also kicks the ball off for testing the app builder elements, I will do more in a seperate PR for the various config points in the library!