Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azure mgmt core to setup #738

Merged
merged 7 commits into from
Aug 5, 2020
Merged

Conversation

iscai-msft
Copy link
Contributor

fixes #729

@iscai-msft iscai-msft requested a review from lmazuel August 3, 2020 20:51
@@ -19,7 +19,7 @@
# prerequisite: setuptools
# http://pypi.python.org/pypi/setuptools

REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0"]
REQUIRES = ["msrest>=0.6.0", "azure-core<2.0.0,>=1.2.0", "azure-mgmt-core>=1.2.0"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowest version is 1.2.0 since we're using the new http_logging_policy property (changelog here)

@@ -1,4 +1,5 @@
{% set name = code_model.options["package_name"] or code_model.class_name %}
{% set azure_mgmt_core_import = ', "azure-mgmt-core>=1.2.0"' if code_model.options["azure_arm"] else "" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"azure-mgmt-core<2.0.0,>=1.2.0"

…into add_azure_mgmt_core_to_setup

* 'autorestv3' of https://github.com/Azure/autorest.python:
  Update package.json
  Update ChangeLog.md
  Add azure key credential param name (#736)
  update x-ms-text based on new m4 treating it as an xml property (#734)
  remove dependency on pytest-asyncio 0.10.0, getting latest version now (#737)
@iscai-msft iscai-msft merged commit 48f172a into autorestv3 Aug 5, 2020
@iscai-msft iscai-msft deleted the add_azure_mgmt_core_to_setup branch August 5, 2020 15:15
iscai-msft added a commit that referenced this pull request Aug 5, 2020
…into polling_interval_in_doc

* 'autorestv3' of https://github.com/Azure/autorest.python:
  Add azure mgmt core to setup (#738)
iscai-msft added a commit that referenced this pull request Aug 7, 2020
…into verify_multipart

* 'autorestv3' of https://github.com/Azure/autorest.python:
  Update package.json
  Update ChangeLog.md
  Replace not extend scopes (#745)
  Have either AzureKeyCredential typing or TokenCredential typing (#744)
  only add polling interval in service client doc if package has lro operations (#732)
  Add azure mgmt core to setup (#738)
  Update package.json
  Update ChangeLog.md
  Add azure key credential param name (#736)
iscai-msft added a commit that referenced this pull request Sep 10, 2020
…into add_nullable_to_validation_map

* 'autorestv3' of https://github.com/Azure/autorest.python: (41 commits)
  add 401 -> ClientAuthenticationError to error map (#763)
  NotImplementedError -> ValueError (#764)
  Update ChangeLog.md
  improve API version error (#752)
  fix warning for BearerTokenCredentialPolicy and no credential scopes (#758)
  update to 4.15.416 (#761)
  Update ChangeLog.md
  remove async suffix (#759)
  Handle m4 accept header parameter (#748)
  Multipart (#746)
  Introduce explode into autorest (#705)
  update azure-core and msrest versions (#747)
  Update package.json
  Update ChangeLog.md
  Replace not extend scopes (#745)
  Have either AzureKeyCredential typing or TokenCredential typing (#744)
  only add polling interval in service client doc if package has lro operations (#732)
  Add azure mgmt core to setup (#738)
  Update package.json
  Update ChangeLog.md
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants