Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove async suffix #759

Merged
merged 4 commits into from
Aug 31, 2020
Merged

remove async suffix #759

merged 4 commits into from
Aug 31, 2020

Conversation

iscai-msft
Copy link
Contributor

fixes #749

@iscai-msft iscai-msft changed the title remove async prefix remove async suffix Aug 28, 2020
iscai-msft
iscai-msft commented Aug 28, 2020
View reviewed changes
test/vanilla/pytest.ini
xfail_strict=true
python_files=test_*.py
Copy link
Contributor Author

@iscai-msft iscai-msft Aug 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this since, without the _asnc suffix, pytest was trying to discover Validation's async service client (it would also recurse into the sync client but no errors would be thrown). The reason it discover's the Validation test's service clients is because the file name ends in test. Here, I'm just telling pytest to discover test files that start with test_

iscai-msft
iscai-msft commented Aug 31, 2020
View reviewed changes
ChangeLog.md
@@ -1,9 +1,13 @@
# Change Log

### 2020-xx-xx - 5.1.0-preview.8
### 2020-xx-xx - 5.2.0-preview.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping minor version since it's a breaking change and the diff is big

@iscai-msft iscai-msft merged commit 7595d24 into autorestv3 Aug 31, 2020
@iscai-msft iscai-msft deleted the remove_async_suffix branch August 31, 2020 16:21
iscai-msft added a commit that referenced this pull request Sep 9, 2020
@iscai-msft
Merge branch 'autorestv3' of https://github.com/Azure/autorest.python …
a35461d 
…into improve_multiapi_api_version_error

* 'autorestv3' of https://github.com/Azure/autorest.python:
  fix warning for BearerTokenCredentialPolicy and no credential scopes (#758)
  update to 4.15.416 (#761)
  Update ChangeLog.md
  remove async suffix (#759)
iscai-msft added a commit that referenced this pull request Sep 10, 2020
@iscai-msft
Merge branch 'autorestv3' of https://github.com/Azure/autorest.python …
19caef1 
…into add_nullable_to_validation_map

* 'autorestv3' of https://github.com/Azure/autorest.python: (41 commits)
  add 401 -> ClientAuthenticationError to error map (#763)
  NotImplementedError -> ValueError (#764)
  Update ChangeLog.md
  improve API version error (#752)
  fix warning for BearerTokenCredentialPolicy and no credential scopes (#758)
  update to 4.15.416 (#761)
  Update ChangeLog.md
  remove async suffix (#759)
  Handle m4 accept header parameter (#748)
  Multipart (#746)
  Introduce explode into autorest (#705)
  update azure-core and msrest versions (#747)
  Update package.json
  Update ChangeLog.md
  Replace not extend scopes (#745)
  Have either AzureKeyCredential typing or TokenCredential typing (#744)
  only add polling interval in service client doc if package has lro operations (#732)
  Add azure mgmt core to setup (#738)
  Update package.json
  Update ChangeLog.md
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel approved these changes

@changlong-liu changlong-liu Awaiting requested review from changlong-liu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iscai-msft @lmazuel