Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ADO image #16299

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Update ADO image #16299

merged 1 commit into from
Nov 18, 2021

Conversation

isra-fel
Copy link
Member

@isra-fel isra-fel commented Nov 1, 2021

Description

Update ADO image from vs2017-win2016 to windows-2019 as win2016 is being removed.

Fix #16275

Test

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@isra-fel
Copy link
Member Author

isra-fel commented Nov 1, 2021

/azp run azure-powershell - windows-powershell

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel
Copy link
Member Author

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel isra-fel marked this pull request as ready for review November 16, 2021 07:01
@isra-fel isra-fel force-pushed the yeming/upgrade-image branch from 967247a to 3caa467 Compare November 17, 2021 07:24
Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel
Copy link
Member Author

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel
Copy link
Member Author

/azp run /azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

No pipelines are associated with this pull request.

@isra-fel
Copy link
Member Author

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel isra-fel merged commit f6b26cd into main Nov 18, 2021
@isra-fel isra-fel deleted the yeming/upgrade-image branch November 18, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The windows-2016 environment used by pipeline (at least smoke test) is going to be deprecated and removed
2 participants