Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customer review updates first implementation #2

Merged
merged 8 commits into from
Dec 14, 2017
Merged

Customer review updates first implementation #2

merged 8 commits into from
Dec 14, 2017

Conversation

fazo96
Copy link
Collaborator

@fazo96 fazo96 commented Dec 6, 2017

I wrote a first implementation of the customer review updates handling using OrbitDB.

What's missing until it can be used:

  • a way to register a callback to listen for review updates from outside the API (this is already in the implementation doc)
  • a format for the data in the OrbitDB feed. At the moment it just writes whatever object is given. OrbitDB can store any JSON-serializable object
  • key import/export for the customer

There is also a test that writes a review updates then checks that it gets replicated automatically to a service node.

This PR includes commits from #1

@fazo96 fazo96 requested a review from kulpreet December 6, 2017 12:37
@fazo96 fazo96 mentioned this pull request Dec 12, 2017
@kulpreet kulpreet merged commit 89b1dbd into ChluNetwork:master Dec 14, 2017
@fazo96 fazo96 deleted the customer-review-updates branch December 19, 2017 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants