Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in-browser tests #7

Merged
merged 11 commits into from
Dec 14, 2017
Merged

Added in-browser tests #7

merged 11 commits into from
Dec 14, 2017

Conversation

fazo96
Copy link
Collaborator

@fazo96 fazo96 commented Dec 12, 2017

Closes #5

This PR includes commits from #1 and #2 so they should be merged before looking at this.

Changes summary:

  • adjusted all tests to use mocha instead of jest, because jest tests can't run in the browser
  • added Karma to run the mocha tests in the browser

Some notes:

  • karma does not run the multi-node tests (the ones involving more than one ChluIPFS node) because connecting directly two IPFS nodes in the browser is tricky. It does run all the other tests though including the ones using a real IPFS node.
  • karma does not run in CI because I can only get it to run "hands free" using chrome which is not available in travis. Firefox is available but I can't figure out how to make it work. I'll try to fix this

Luckily almost no changes were needed to get ChluIPFS to run in the browser.

@fazo96 fazo96 requested a review from kulpreet December 12, 2017 15:11
@kulpreet kulpreet merged commit 658aa25 into ChluNetwork:master Dec 14, 2017
@fazo96 fazo96 deleted the browser-tests branch December 19, 2017 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for the browser
2 participants