Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide billing card in payment methods page #8746

Merged
merged 4 commits into from
Apr 22, 2022
Merged

Hide billing card in payment methods page #8746

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c52b414
hide the billing card in payment methods
techievivek Apr 22, 2022
55049de
fixed linter issue
techievivek Apr 22, 2022
527f086
fixed linter issue
techievivek Apr 22, 2022
01343be
added proper comment
techievivek Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/pages/settings/Payments/PaymentMethodList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,10 @@ class PaymentMethodList extends Component {
* @returns {Array}
*/
getFilteredPaymentMethods() {
let combinedPaymentMethods = PaymentUtils.formatPaymentMethods(this.props.bankAccountList, this.props.cardList, this.props.payPalMeUsername, this.props.userWallet);
// Hide the billing card from the payments menu for now because you can't make it your default method, or delete it
const filteredCardList = _.filter(this.props.cardList, card => !card.additionalData.isBillingCard);

let combinedPaymentMethods = PaymentUtils.formatPaymentMethods(this.props.bankAccountList, filteredCardList, this.props.payPalMeUsername, this.props.userWallet);

if (!_.isEmpty(this.props.filterType)) {
combinedPaymentMethods = _.filter(combinedPaymentMethods, paymentMethod => paymentMethod.accountType === this.props.filterType);
Expand Down