WP Updates #5
Merged
WP Updates #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Avoid getBlock in block-list/block * Update data docs * Fix unit tests post rebase :) * Rename props * Clarify the filter position * Avoid repeating the selector dependants * Fix small typo in the docs * Avoid rerending the current block if the previous block change (#12379) * Avoid rerending the current block if the previous block change * Always show the sibling inserter * Optimize the insertion point component (#12384) * Fix lock file * Fix linting
…mentation (#11640) The documentation of "Managing block categories" was wrong as on the server we can not set SVG icons. The server would not be able to use our SVG component. This PR fixes the documentation and adds a new action that allows updating the icon on the front end in a simple way.
* RichText: Reuse DOM document across calls to createEmpty * RichText: Reuse document in createElement * Rich Text: Update tests to clone node to retain reference * Rich Text: Refactor createEmpty to use createElement
* Parser: Make attribute parsing possessive Bug introduced in #11369 Someone discovered high CPU usage due to catastrophic backtracking on an invalid block comment delimiter. The following input crashed the parser on the server: ```html <!-- wp:block {"a":0} / --> ``` The optimization introduced in #11369 ended up opening a place for backtracking that shouldn't be there. In this patch we're grouping the attribute parsing section of the tokenizing RegExp pattern so that we can make the group itself _possessive_ so that we abort any backtracking. * add test and fix broken fix * really fix default JS parser * add explanatory comment * add @SInCE comment with updated target version * version bumps
* RichText: selectionChange: bind on focus, unbind on blur * Remove isActive check
* Update package changelogs * Bump plugin version to 4.6.1 * chore(release): publish - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] * Update changelogs after the package release
* Allow links in Plugins group in the More Menu * Docs: Add documentation for PluginMoreMenuItem * Tests: Add unit tests for PluginMoreMenuItem * Refactor PluginSidebarMoreMenuItem to use PluginMoreMenuItem * Docs: Add note about supported props for PluginMoreMenuItem * Edit post: Use props to pass children in PluginMoreMenuItem * Use href rather than url prop in PluginMoreMenuItem component
* Docs: Stop using el variable in edit post docs * Docs: Move extending the post editor UI to package README
## Description Following on from #12411 and #11817 it was noticed that some pages were skipped, as they weren't included in the `toc.json` file previously. This PR includes several specific fixes which are all interconnected: 1. Adds the Internationalization page along with the Block Tutorial to the handbook hierarchy 1. An additional landing page for the Tutorials index was added 1. `Components` was added to the developers handbook alongside `Packages` and `Data Package Reference` pages. 1. In order to handle the above move, the duplicative declarations of `Packages`, `Data Package Reference` and `Components` were removed from `docs/tool/manifest.js` to prevent them adding as top-level-items. (Are these intended to be top-level-handbook-pages or deep within the developers handbook as the TOC seems to suggest?) I also took the opportunity to convert `generate.php` from the previous PR into a JS command that allows for `docs/root-manifest.json` to be removed entirely and dynamically generated from `docs/toc.json` so it only needs updating in a single location. That's the `getRootManifest()` and `generateRootManifestFromTOCItems()` functions which are rather messy, but work (I'm sure someone else could clean that up significantly). ## How has this been tested? The only testing done so far is the manual review of the final `docs/manifest.json`.
## Description <!-- Please describe what you have changed or added --> Makes existing HTML links clcikable ## How has this been tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, tests ran to see how --> <!-- your change affects other areas of the code, etc. --> Links are not clickable at https://wordpress.org/gutenberg/handbook/contributors/history/ ## Screenshots <!-- if applicable --> ## Types of changes <!-- What types of changes does your code introduce? --> <!-- Bug fix (non-breaking change which fixes an issue) --> <!-- New feature (non-breaking change which adds functionality) --> <!-- Breaking change (fix or feature that would cause existing functionality to not work as expected) --> Docs ## Checklist: - [x] My code is tested. - [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ --> - [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ --> - [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->
The adding-inline-tokens.test.js test was failing on Travis, instead of an image upload being successful we got an error reporting that no permissions exist. This commit uses 2 commands on the docker container to do the following actions: Create an uploads folder inside wp-content. Change the folder permissions to 766. 766 was chosen because according to the hierarchy we should follow when trying to fix permission problems available in https://codex.wordpress.org/Changing_File_Permissions is the most adequate value. The value bellow it (765) does not work.
* Edior: Fix regression introduced in CopyHandler * Refactor CopyHandler to be less dependent on withData implementation
* Fixes for i18n docs. Clarify wording/examples. * Clarify sentence about babel plugin * Always capitalize I18N abbreviaton.
* docs: Remove "1440" line The first line in a project's repo should be more explanative than quippy 😅 Besides: the GitHub description already contains that exact sentence. I find it sort of obscure and not very helpful; it probably confuses plenty of younger people unaware that we used to read these things called "books", "printed" on "paper". 😆 * docs: Tweak alt attribute
This patch adds myself to the list of Gutenberg contributors list for an e2e test I committed on Dec 3 🎉
* Testing: add e2e test for the HTML block * chore: Tweak test spec name * chore: Tweak test spec name
Removed "Visit the User Handbook" link from ##User Handbook Section. ## Description We have removed "Visit the User Handbook" link from User Handbook section. Reff. #12585.
* Add details on installing/using packages * docs: a few tweaks
## Description The FAQ appears to be originally written in 2017 when the project was a bit younger. I've taken a stab at updating with more current information and what we now know. I also included a link to Matt's own FAQ around Gutenberg and WordPress 5.0, which likely has more recent information and questions. Fixes #8535 ## Types of changes Documentation update.
* Update broken links There was 2 broken links. I changed same way with Data Module Reference page. * Update docs/designers-developers/developers/block-api/README.md Co-Authored-By: cagdasdag <[email protected]> * Update docs/designers-developers/developers/block-api/README.md Co-Authored-By: cagdasdag <[email protected]>
* Update glossar with missing terms * Convert glossary to use dl/dt/dd dtags. Fixes #9976 * Fix TinyMCE link * remove spacing around tags * Add template definition, with link * Updates per review * Update docs/designers-developers/glossary.md Co-Authored-By: mkaz <[email protected]>
…12570) * Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` * Whitespace * Consistant Capit… i mean capitalization * Oxford comma Co-Authored-By: georgeh <[email protected]>
* Cache createBlock call in isUnmodifiedDefaultBlock * Invalidate cache when default block name changes * Merge ifs
Hiding disabled meta boxes by setting `element.style.display = 'none'` interferes with plugins like ACF which rely on being able to show and hide meta boxes using `$.hide()` and `$.show()`. Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden` class ensures that we don't interfere with third party code.
* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary * Fix typo and missing space in scss comment
…tyles before wp-edit-blocks. (#12619)
* get wordcount type from translation * Add description to explain the options for wordcount type * Added mylsef into contributors.md. :)
* Fix issue where default appender has icons overlaying the text This fixes #11425. It adds padding to the right of the default block appender to fit 3 icons. * chore: Tweak spelling
* Classic Block: set correct focus back after blur * Add e2e test * reset bookmark on mousedown and touchstart * e2e: Look for aria-label="Add Media" rather than "Insert Media"
* RichText: only set range if different * Check rangeCount * Also compare nodes * Add e2e test * Simplify * RichText: Document isRangeEqual * Testing: RichText: Assure subscriber removal * Unsubscribe in page.evaluate
* When a post is saved, check for tinymce and save any editors. * Importing tinymce and using tinyMCE vs the object stored in window.tinymce. * Updated version number and changelog. * no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case. * Using typeof to check for tinyMCE and fixed issues brought up in travis run. * using window.tinyMCE again to avoid warning RE undefined var * Restore the package.json version. * Add e2e tests for the custom wp_editor metaboxes
* Rename functions, removing gutenberg_ and prefixing with wp_ * Remove wp_ prefix to match core * Remove function check per review
* Try: JS Console warning for when in Quirks Mode This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render. This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378. The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content. The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text: ``` [Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins. ``` It also augments the documentation to add a note about this. * Move warning to index.js * Remove try/catch. * Tweak: Remove redundant [warning] in warn call
…ers-developers directory in the repo (#12745)
* Rename backwards compatiblity to backward compatibility * Remove package-lock from commit * Update CONTRIBUTING.md Co-Authored-By: mkaz <[email protected]> * Update CONTRIBUTING.md Co-Authored-By: mkaz <[email protected]> * Whitespace in manifest
## Description Fixes #12539 by updating node-sass to support Node.js 11. ## How has this been tested? Running `npm install` on macOS 10.14 with Node.js 11.2 without problems. ## Types of changes Minor dependency bump to support Node.js 11. ## Checklist: - [x] My code is tested. - [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ --> - [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ --> - [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->
* Add attributes to ServerSideRender readme Adds a code example demonstrating how to define attributes when registering a block that will use attributes in a ServerSideRender component. * Add whitespace and inline code markup to ServerSideRender readme Implements requested changes from code review.
* Scripts: Add check-engines script to the package * Update packages/scripts/CHANGELOG.md Co-Authored-By: gziolo <[email protected]> * Update packages/scripts/README.md Co-Authored-By: gziolo <[email protected]> * Update minimal node version to 10.x Co-Authored-By: gziolo <[email protected]>
* Chore: Remove unused npm dependencies from the root package.json file * Move devDependencies to root package.json file
* Packages: Move eslint-config to eslint-plugin (Fails pre-commit, but in effort to ensure history preservation) * eslint-plugin: Add npmrc to avoid package-lock.json * Framework: Update path references for eslint-config to -plugin * eslint-plugin: Reimplement ESLint config as plugin * eslint-plugin: Unmark as private * eslint-plugin: Undocument custom ruleset
* Bump plugin version to 4.7.0 * chore(release): publish - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] * Update changelogs after 4.7 package releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
Screenshots
Types of changes
Checklist: