Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translated Javascript and Markup chapter to Italian #1958

Merged
merged 20 commits into from
Feb 5, 2021
Merged

Translated Javascript and Markup chapter to Italian #1958

merged 20 commits into from
Feb 5, 2021

Conversation

chefleo
Copy link
Contributor

@chefleo chefleo commented Feb 1, 2021 •
edited by tunetheweb
Loading

Makes progress on #585

chefleo and others added 16 commits December 26, 2020 17:00
@chefleo
Create Italian Resource-Hints
ebf6644
@chefleo
Translated html files in italian
1d05240
@chefleo
Update 2020.json
5831933
@chefleo
Update language and fix translation
5b90861
@chefleo
Fix and update files
0ab4372
@chefleo
Fix and update files
816599a
@Zizzamia @tunetheweb
fix: highlight English phrases
f9b29ba 
Co-authored-by: Barry Pollard <[email protected]>
@Zizzamia @tunetheweb
fix: caption
f21e4c7 
Co-authored-by: Barry Pollard <[email protected]>
@Zizzamia @tunetheweb
fix: remove TODO
095ca82 
Co-authored-by: Barry Pollard <[email protected]>
@Zizzamia @tunetheweb
fix: remove TODO
5e117bd 
Co-authored-by: Barry Pollard <[email protected]>
@Zizzamia @tunetheweb
fix: added back missing comments
5ec540b 
Co-authored-by: Barry Pollard <[email protected]>
@Zizzamia @tunetheweb
fix: error page
52083d8 
Co-authored-by: Barry Pollard <[email protected]>
@tunetheweb
Contributori to Collaboratori
ec827e1
@chefleo
Update fork
283e4fb
@chefleo
Translate italian markup.md until Favicon
6a89471
@chefleo
Finish translate Javascript and Markup
8e918bb
tunetheweb
tunetheweb requested changes Feb 1, 2021
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted some things to change.

You may need to merge main into your branch to get this to work.

Will do another review once these are fixed.

@chefleo
Update files
07a9fa3
@chefleo
Merge remote-tracking branch 'upstream/main' into main
2fe5d18 
* upstream/main: (70 commits)
  Do fuller HTML linting checks on generated HTML (HTTPArchive#1959)
  Extend height of AMP Stories images (HTTPArchive#1957)
  Change Introductie to Inleiding (HTTPArchive#1956)
  Bump peter-evans/create-pull-request from v3.7.0 to v3.8.0 (HTTPArchive#1955)
  Update Timestamps and Generate Ebooks (HTTPArchive#1953)
  Update total number of pages in ebook to 600! (HTTPArchive#1952)
  Remove control characters causing HTML validation errors (HTTPArchive#1951)
  2020 javascript japanese translation (HTTPArchive#1937)
  Translation of 2020 accessibility chapter to Japanese (HTTPArchive#1949)
  Fix figure links and footnotes for ebook (HTTPArchive#1950)
  Fix hide description bug (HTTPArchive#1948)
  Update Timestamps and Generate Ebooks (HTTPArchive#1947)
  Smart Quotes for English non-chapter pages (HTTPArchive#1946)
  Typographical quotes for metadata (HTTPArchive#1945)
  Fix figure number bug (HTTPArchive#1944)
  Update Timestamps and Generate Ebooks (HTTPArchive#1943)
  Revert "Revert "Add typographic punction conversion"" (HTTPArchive#1942)
  Add Nuxt and Docusauraus to Jamstack 2020 chapter (HTTPArchive#1938)
  Revert "Add typographic punction conversion"
  Add typographic punction conversion
  ...
tunetheweb
tunetheweb requested changes Feb 1, 2021
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a few more things. But other than that looks good to me from a technical point of view! Will leave the others to comment on the Italian 😀

One thing to note is some of the anchors will change as we translate the other chapters. For example this:

secondo il capitolo [Accessibilità](./accessibility#language-identification)

Might need to be changed as the anchors ("language-identification") are based on the headings. So when we translate the Accessibility chapter we might need to revisit this one. But not much we can do about that now so best to leave as is for now.

@tunetheweb tunetheweb added the translation world wide web label Feb 1, 2021
@tunetheweb tunetheweb added this to the 2020 Content Translation milestone Feb 1, 2021
@tunetheweb tunetheweb changed the title Translated Javascript and Markup chapter Translated Javascript and Markup chapter to Italian Feb 1, 2021
@tunetheweb tunetheweb mentioned this pull request Feb 1, 2021
Open
@tunetheweb
Copy link
Member

Doing a release so going to merge this. @HTTPArchive/italian-translators if any of you do get a chance to review and spot something then let's correct in a future pull request.

@chefleo could you reset your main branch so we don't get the full history of commits with your next pull request? Not a massive issue as we squash and commit, but just makes the pull request a big noisy.

Great job on these two btw!

@tunetheweb tunetheweb merged commit 5421a9a into HTTPArchive:main Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunetheweb tunetheweb tunetheweb approved these changes

@giopunt giopunt Awaiting requested review from giopunt

@Zizzamia Zizzamia Awaiting requested review from Zizzamia

Assignees
No one assigned
Labels
translation world wide web
Projects
None yet
Milestone
2020 Content Translation
Development

Successfully merging this pull request may close these issues.
3 participants
@chefleo @tunetheweb @Zizzamia