-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pako from 1.0.11 to 2.0.3 #863
Conversation
Rotate in place when flattening
Support hidden form fields
adding information about font subset
731 cleanup
Update README.md
* Ensure appearance streams are generated when missing * Reset scratchpad
* more ViewerPreferences address issue Hopding#744 * PDFHexString ViewerPreferences * Update ViewerPreferences.ts * neaten ViewerPreferences * type assertIsOneOf values * clearer documentation of viewerPreferences * Update tsconfig target * README with viewer pref * tests for viewer preferences * more ViewerPreferences address issue Hopding#744 * revert to ES5 target * fix tsconfig es case ensure it does not show up as a change in the diff * address Hopding coments 1 * minor viewerpref doc changes * doc viewerPref with pageMode * set pagemode * test existing viewerPrefs in doc * document viewerPref enums * lint viewerPreferences * comment linting * comments in 0 printpage index
Cleanup 745
* Remove all fields & widget annotations when flattening Enhance `removeField` to cleanup annotations * Add `removeField` test
Cleanup 750
* Adding ability to change font size in PDF form fields * Implementing @Hopding's recommended changes for PR * Fixing bug in validator * Resolving conflict * Changing tabs to spaces Co-authored-by: Tim Knapp <[email protected]>
Cleanup 754b
Can we help to have this MR accepted? Should the We also need a newer version of pako to bundle pdf-lib in our rollup build process :) |
Hello @ElectroluxV2! Thanks so much for working on this! Apologies for my late response. I've been very busy these past few months taking care of some personal stuff and starting my new job at GitHub 🙂 I'm hoping to get around to reviewing this PR in the next few weeks now that I've got some more free time. Please note that you'll need to either update this PR (via a force push) or open a new PR with your changes. The tl;dr is that I recently had to do a fairly extensive git history rewrite that caused a bunch of conflicts. Please read https://github.com/Hopding/pdf-lib#git-history-rewrite for details. Apologies for the hassle! |
@ElectroluxV2 I'm happy to reopen and review your work if you get around to reapplying your changes on the latest |
Hi,
referring to #689, and taking into account that types for pako did not change you can bump dependency. I have tested that lib still builds.