Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Progress bars wording improvements while opening a service #7102

Merged
merged 2 commits into from
Jan 28, 2025
Merged

🎨 Progress bars wording improvements while opening a service #7102

merged 2 commits into from
Jan 28, 2025

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jan 27, 2025 •
edited
Loading

What do these changes do?

I have tagged a few of you since I'm unsure how to deal with the linked issue the this PR tries to close. Please aid me.

Applies changes from team black ITISFoundation/osparc-issues#1399

I don't know if we want to go with these suggestions or refute the suggestions.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Jan 27, 2025
@GitHK GitHK added the a:frontend issue affecting the front-end (area group) label Jan 27, 2025
@GitHK GitHK added this to the Singularity milestone Jan 27, 2025
@GitHK GitHK marked this pull request as ready for review January 27, 2025 15:19
pcrespov
pcrespov reviewed Jan 27, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the title a bit more specific in the title since it is afterwards used for release notes

sanderegg
sanderegg approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the title of the PR. Thanks

@GitHK GitHK changed the title 🎨 Team black feedback 🎨 Progress bars wording improvements while opening studies Jan 28, 2025
@GitHK GitHK changed the title 🎨 Progress bars wording improvements while opening studies 🎨 Progress bars wording improvements while opening services Jan 28, 2025
@GitHK GitHK changed the title 🎨 Progress bars wording improvements while opening services 🎨 Progress bars wording improvements while opening a service Jan 28, 2025
@GitHK GitHK added 🤖-do-not-merge (optional) blocks Mergify from merging the PR 🤖-automerge marks PR as ready to be merged for Mergify and removed 🤖-do-not-merge (optional) blocks Mergify from merging the PR 🤖-automerge marks PR as ready to be merged for Mergify labels Jan 28, 2025
@GitHK GitHK added the 🤖-automerge marks PR as ready to be merged for Mergify label Jan 28, 2025
@JavierGOrdonnez
Copy link

JavierGOrdonnez commented Jan 28, 2025 •
edited
Loading

May I take this chance to ask what exactly is Team Black and whether it is active at the moment? Eli seemed to have been involved in that but she never mentioned it in the knowledge transfer before leaving. @GitHK

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mergify mergify bot merged commit e042a69 into ITISFoundation:master Jan 28, 2025
57 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 30, 2025
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov approved these changes

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@ignapas ignapas ignapas approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@sanderegg sanderegg sanderegg approved these changes

@JavierGOrdonnez JavierGOrdonnez JavierGOrdonnez approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007

@calys calys Awaiting requested review from calys

@wvangeit wvangeit Awaiting requested review from wvangeit

Assignees

@GitHK GitHK

Labels
🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
Singularity
Development

Successfully merging this pull request may close these issues.

Improve wording of progress bars while opening studies
8 participants
@GitHK @JavierGOrdonnez @giancarloromeo @ignapas @pcrespov @odeimaiz @sanderegg @matusdrobuliak66