Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with skeleton loaders throughout the app #4176

Open
arrenv opened this issue Jan 24, 2025 · 2 comments · May be fixed by #2448
Open

Issues with skeleton loaders throughout the app #4176

arrenv opened this issue Jan 24, 2025 · 2 comments · May be fixed by #2448
Assignees
@rdig
Labels
bug Something isn't working Priority: P3 (Low) qa For fixes found during a qa session

Comments

@arrenv
Copy link
Member

arrenv commented Jan 24, 2025

Steps to reproduce

  1. Load any page in the app that has a skeleton loader.
  2. Note the appearance of the loader.

Expected behaviour

  • The skeleton loaders should align with the design and not break the layout of the UI.

Actual behaviour

  • Skeleton loaders are breaking the UI throughout the app and do not align with the design.

QA

Image

Image

Production

Image

Image
@arrenv arrenv added bug Something isn't working qa For fixes found during a qa session labels Jan 24, 2025
@rdig rdig mentioned this issue Jan 24, 2025
Closed
@rdig rdig self-assigned this Jan 29, 2025
@rdig rdig linked a pull request Jan 29, 2025 that will close this issue
Open
@melyndav
Copy link

Image

Just adding that it's happening inline in actions as well so we can be sure to test this once a new fix is deployed.

@rdig
Copy link
Member

rdig commented Jan 29, 2025

Already fixed all of this, will deploy the update shortly

rdig added a commit that referenced this issue Jan 29, 2025
@rdig
Fix: remove dynamic wallet shadow dom disable
426d0f1 
Fixes #4176
jakubcolony pushed a commit that referenced this issue Feb 5, 2025
@rdig @jakubcolony
Fix: remove dynamic wallet shadow dom disable
4d29a82 
Fixes #4176
jakubcolony pushed a commit that referenced this issue Feb 7, 2025
@rdig @jakubcolony
Fix: remove dynamic wallet shadow dom disable
83f6ec4 
Fixes #4176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdig rdig

Labels
bug Something isn't working Priority: P3 (Low) qa For fixes found during a qa session
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for the Dynamic(xyz) wallet library JoinColony/colonyCDapp
3 participants
@rdig @arrenv @melyndav