Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add encoder #1

Merged
merged 11 commits into from
May 11, 2021
Merged

add encoder #1

merged 11 commits into from
May 11, 2021

Conversation

johnnychen94
Copy link
Member

@johnnychen94 johnnychen94 commented May 4, 2021

Preview:

image

Todo:

  • docs
  • test
  • Features
    • io redirection so that we can appropriately test the functionalities in CI (WIP: use low level sixel_encode #2)
    • expose encoder control flags as keyword arguments (currently only transpose)
    • query terminal information
    • default palette might be runtime dependent. Probably we should not hardencode them in default_palette.
  • Nice-to-have
    • gif and video support. (5bd3f30) (reverted in 45a7ec3, will be added to ImageInTerminal)
    • better support for Gray{Bool} type.
    • AGray{N0f8} and GrayA{N0f8} are currently converted to ARGB.

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #1 (63cbd9d) into master (2876d7c) will increase coverage by 24.33%.
The diff coverage is 24.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #1       +/-   ##
===========================================
+ Coverage        0   24.33%   +24.33%     
===========================================
  Files           0        7        +7     
  Lines           0      263      +263     
===========================================
+ Hits            0       64       +64     
- Misses          0      199      +199     
Impacted Files Coverage Δ
src/interface.jl 0.00% <0.00%> (ø)
src/terminaltools.jl 0.00% <0.00%> (ø)
src/backend/libsixel/CModule.jl 3.18% <3.18%> (ø)
src/backend/libsixel/encoder.jl 72.22% <72.22%> (ø)
src/Sixel.jl 80.00% <80.00%> (ø)
src/encoder.jl 85.71% <85.71%> (ø)
src/backend/libsixel/types.jl 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2876d7c...63cbd9d. Read the comment docs.

@johnnychen94 johnnychen94 marked this pull request as ready for review May 11, 2021 11:09
@johnnychen94 johnnychen94 changed the title [WIP] add encoder add encoder May 11, 2021
@johnnychen94
Copy link
Member Author

After playing with this for over a week, I'm now quite satisfied with the current design. Hence I'm going to make this the initial commit to the master.

Windows is currently broken (#5), I'll try to fix that but can't promise anything (as GSoC 2021 is about to start)

@johnnychen94 johnnychen94 merged commit 373d50b into master May 11, 2021
@johnnychen94 johnnychen94 deleted the jc/encoder branch May 11, 2021 15:20
johnnychen94 added a commit that referenced this pull request May 11, 2021
This was accidentally commited in #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant