WIP: use low level sixel_encode #2
Merged
+119
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## jc/encoder #2 +/- ##
=============================================
- Coverage 2.91% 0.00% -2.92%
=============================================
Files 3 3
Lines 206 228 +22
=============================================
- Hits 6 0 -6
- Misses 200 228 +28
Continue to review full report at Codecov.
|
Gnimuc
reviewed
May 8, 2021
Gnimuc
reviewed
May 8, 2021
Gnimuc
reviewed
May 8, 2021
src/encoder.jl
Outdated
| function SixelEncoder(io::IO, img::AbstractArray) | ||
| allocator = SixelAllocator() | ||
|
|
||
| colorbits = default_colorbits(img) | ||
| pixelformat = default_pixelformat(img) | ||
| io = maybe_convert(SixelIOBuffer, io) | ||
| SixelEncoder(io, colorbits, pixelformat, allocator) | ||
| end | ||
|
|
||
| function sixel_write_callback_function(buffer_ptr::Ptr{Cchar}, sz::Cint, priv::Ref{T})::Cint where {T<:IO} | ||
| io = unsafe_load(Base.unsafe_convert(Ptr{T}, priv)) |
There was a problem hiding this comment.
Oops! This io is created by unsafe_load which is a copy of the referenced value in the priv(a Ref).
In fact, there is no need to do this unsafe_load. priv is already a Ref{IO} type as we use the parametric type. So the body of this callback function should be:
unsafe_write(priv[], buffer_ptr, sz)
That's it. I'm sorry for the confusion.
Co-authored-by: Yupei Qi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MWE is in
demo.jl:cc: @Gnimuc