Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

Add changeset endpoint #743

Closed
wants to merge 1 commit into from
Closed

Add changeset endpoint #743

wants to merge 1 commit into from

Conversation

leplatrem
Copy link
Contributor

In kinto-changes we added a new .../changeset endpoint.

@glasserc do you think I could add it here? Or I should improve #742 to support that use-case?

Thanks for your feedback :)

@github-actions
Copy link

github-actions bot commented Apr 6, 2020

Size Change: +138 B (0%)

Total Size: 38.5 kB

Filename Size Change
dist/kinto-http.min.js 8.62 kB +50 B (0%)
dist/kinto-http.node.js 14.3 kB +53 B (0%)
dist/moz-kinto-http-client.js 15.5 kB +35 B (0%)

compressed-size-action

@glasserc
Copy link
Contributor

glasserc commented Apr 6, 2020

I definitely think #742 is a nicer, more extensible approach to this problem. The server is built around the concept of plugins, so I guess the client should be too, right?

@leplatrem
Copy link
Contributor Author

With what I propose in #742, it could become:

const path = client.endpoints.changeset(bid, cid);
await client.execute(path, { query: { _expected: 42 } });

I think it's better :) kinto-changes could be renamed kinto-remotesettings and I don't think this should go in the basic kinto http client

@leplatrem leplatrem closed this Apr 7, 2020
@leplatrem leplatrem deleted the add-changeset-endpoint branch April 7, 2020 16:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants