Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some accessors for MATModel #602

Merged
merged 3 commits into from
Apr 8, 2022
Merged

Add some accessors for MATModel #602

merged 3 commits into from
Apr 8, 2022

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented Apr 8, 2022

Add some small accessors to MATModel so that the consensus yeast model can at least be imported without error. The model uses too many non-standard fields to make the import process totally smooth...

@stelmo stelmo requested a review from exaexa April 8, 2022 09:16
@cylon-x
Copy link
Collaborator

cylon-x commented Apr 8, 2022

🟢  Commit 31a4490 is formatted properly.

Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor non-critical improvements possible but it looks okay to me...

maybe we could just throw the yeastGEM model to the tested ones?

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #602 (c5ccab9) into develop (d336a7d) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #602      +/-   ##
===========================================
+ Coverage    90.29%   90.35%   +0.05%     
===========================================
  Files           69       69              
  Lines         1721     1731      +10     
===========================================
+ Hits          1554     1564      +10     
  Misses         167      167              
Impacted Files Coverage Δ
src/base/types/MATModel.jl 91.80% <100.00%> (+0.89%) ⬆️
src/base/utils/guesskey.jl 75.00% <100.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ffc36...c5ccab9. Read the comment docs.

@stelmo stelmo requested a review from exaexa April 8, 2022 09:53
@cylon-x
Copy link
Collaborator

cylon-x commented Apr 8, 2022

🟥  Commit 536e679 requires formatting!

Required formatting changes summary:

 src/base/constants.jl      |  5 ++---
 src/base/types/MATModel.jl | 12 ++++++++----
 2 files changed, 10 insertions(+), 7 deletions(-)

@cylon-x
Copy link
Collaborator

cylon-x commented Apr 8, 2022

🟢  Commit c5ccab9 is formatted properly.

Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm&fftm

also I realized that reaction_name and metabolite_name gets kinda auto-tested when converting the models around to JSON/SBML ones, which is great.

@stelmo stelmo merged commit 0869d36 into develop Apr 8, 2022
@stelmo stelmo deleted the mo-mat-import branch April 8, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants