-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some accessors for MATModel #602
Conversation
🟢 Commit 31a4490 is formatted properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor non-critical improvements possible but it looks okay to me...
maybe we could just throw the yeastGEM model to the tested ones?
Codecov Report
@@ Coverage Diff @@
## develop #602 +/- ##
===========================================
+ Coverage 90.29% 90.35% +0.05%
===========================================
Files 69 69
Lines 1721 1731 +10
===========================================
+ Hits 1554 1564 +10
Misses 167 167
Continue to review full report at Codecov.
|
🟥 Commit 536e679 requires formatting! Required formatting changes summary:
|
🟢 Commit c5ccab9 is formatted properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm&fftm
also I realized that reaction_name and metabolite_name gets kinda auto-tested when converting the models around to JSON/SBML ones, which is great.
Add some small accessors to MATModel so that the consensus yeast model can at least be imported without error. The model uses too many non-standard fields to make the import process totally smooth...