Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop→master for 1.3.1 #620

Merged
merged 25 commits into from
May 16, 2022
Merged

Develop→master for 1.3.1 #620

merged 25 commits into from
May 16, 2022

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented May 16, 2022

No description provided.

exaexa and others added 23 commits May 2, 2022 08:55
(this reduces the amount of waiting for network communication)

Closes #603
switch to `asyncmap` for fetching results from multiple workers
Update mods to handle gecko model
Check format using github actions, implement the `/format` command
@exaexa exaexa requested review from stelmo and laurentheirendt May 16, 2022 12:26
@github-actions
Copy link
Contributor

🟢  Commit 78eb5bd is formatted properly.

@github-actions
Copy link
Contributor

🟢  Commit 6d0e83c is formatted properly.

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #620 (02e0c7f) into master (535aaa4) will increase coverage by 0.12%.
The diff coverage is 90.14%.

❗ Current head 02e0c7f differs from pull request most recent head 6d0e83c. Consider uploading reports for the commit 6d0e83c to get more accurate results

@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
+ Coverage   90.29%   90.42%   +0.12%     
==========================================
  Files          78       79       +1     
  Lines        1876     1922      +46     
==========================================
+ Hits         1694     1738      +44     
- Misses        182      184       +2     
Impacted Files Coverage Δ
src/base/types/MetabolicModel.jl 89.39% <ø> (ø)
src/base/utils/enzymes.jl 28.57% <0.00%> (-4.77%) ⬇️
src/base/types/wrappers/GeckoModel.jl 91.66% <83.33%> (+6.37%) ⬆️
src/reconstruction/gapfill_minimum_reactions.jl 90.69% <90.69%> (ø)
src/analysis/gecko.jl 100.00% <100.00%> (ø)
src/analysis/sampling/warmup_variability.jl 100.00% <100.00%> (ø)
src/analysis/screening.jl 97.87% <100.00%> (ø)
src/base/solver.jl 96.42% <100.00%> (+0.13%) ⬆️
src/base/types/Gene.jl 100.00% <100.00%> (ø)
src/base/utils/gecko.jl 100.00% <100.00%> (+10.00%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3f89fd...6d0e83c. Read the comment docs.

@exaexa exaexa merged commit 74bd583 into master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants