-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some constructors #654
Conversation
/format |
✔️ Auto-formatting triggered by this comment succeeded, commited as 55f79ec |
Codecov Report
@@ Coverage Diff @@
## develop #654 +/- ##
========================================
Coverage 91.05% 91.06%
========================================
Files 82 82
Lines 2012 2014 +2
========================================
+ Hits 1832 1834 +2
Misses 180 180
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be rebased when the DSE PR is merged. (#661)
Also, shouldn't we use Base.@kwdef
or some of the pals as we do with SBML? It makes this kind of constructors automagically.
Ref: https://github.com/LCSB-BioCore/SBML.jl/blob/master/src/structs.jl#L413
Oh yeah, |
55f79ec
to
2393904
Compare
Ah actually, I want the docstrings, not sure if kwdef adds docstrings by default? |
/format |
✔️ Auto-formatting triggered by this comment succeeded, commited as 6a1c1ca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool
Useful for model building. Basically moved the existing internal constructors outside so that they can be documented and appear when you look for them at the repl.