Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pFBA pipe #747

Merged
merged 19 commits into from
Mar 5, 2023
Merged

pFBA pipe #747

merged 19 commits into from
Mar 5, 2023

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented Feb 12, 2023

Adds a basic pipe-able pFBA variant. Should play nicely with more interesting model types, e.g. enzyme constrained etc.

gm_changed_bound =
    model |>
    with_changed_bound("BIOMASS_Ecoli_core_w_GAM", lower_bound = growth_lb) |>
    with_enzyme_constraints(
        gene_product_mass_group_bound = Dict(
            "uncategorized" => total_gene_product_mass,
        ),
    )

pfba_sol =
  gm_changed_bound |>
  with_parsimonious_solution(:enzyme) |>
  flux_balance_analysis(Clarabel.Optimizer)

@exaexa what do you think?

@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Patch coverage: 73.46% and project coverage change: +0.33 🎉

Comparison is base (c3ee550) 88.30% compared to head (a58407a) 88.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #747      +/-   ##
==========================================
+ Coverage   88.30%   88.63%   +0.33%     
==========================================
  Files          90       89       -1     
  Lines        2248     2262      +14     
==========================================
+ Hits         1985     2005      +20     
+ Misses        263      257       -6     
Impacted Files Coverage Δ
src/analysis/flux_balance_analysis.jl 100.00% <ø> (+22.22%) ⬆️
src/analysis/minimize_metabolic_adjustment.jl 100.00% <ø> (ø)
src/analysis/modifications/generic.jl 60.00% <ø> (ø)
src/analysis/parsimonious_flux_balance_analysis.jl 80.00% <ø> (ø)
src/wrappers/MatrixCoupling.jl 89.47% <ø> (ø)
src/wrappers/misc/MatrixModel.jl 100.00% <ø> (ø)
src/wrappers/misc/enzyme_constrained.jl 100.00% <ø> (ø)
src/wrappers/misc/mmdf.jl 100.00% <ø> (ø)
src/wrappers/misc/simplified_enzyme_constrained.jl 100.00% <ø> (ø)
src/wrappers/MinimizeDistance.jl 57.69% <57.69%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stelmo stelmo requested a review from exaexa February 12, 2023 22:19
@stelmo stelmo added the do not merge When a PR is labelled as such, do not merge label Feb 12, 2023
@exaexa exaexa added this to the v2.0 milestone Feb 16, 2023
@stelmo stelmo mentioned this pull request Feb 17, 2023
@stelmo stelmo closed this Feb 20, 2023
@stelmo stelmo reopened this Feb 20, 2023
@stelmo stelmo removed the do not merge When a PR is labelled as such, do not merge label Feb 20, 2023
@stelmo
Copy link
Collaborator Author

stelmo commented Feb 20, 2023

/format

triggered by @stelmo on PR #747
@github-actions
Copy link
Contributor

✔️ Auto-formatting triggered by this comment succeeded, commited as dabbe84

@stelmo
Copy link
Collaborator Author

stelmo commented Feb 20, 2023

/format

triggered by @stelmo on PR #747
@github-actions
Copy link
Contributor

✔️ Auto-formatting triggered by this comment succeeded, commited as f916bfb

@stelmo
Copy link
Collaborator Author

stelmo commented Feb 20, 2023

NOTE: variables are not the semantic variables!

@stelmo
Copy link
Collaborator Author

stelmo commented Feb 20, 2023

this poses problems for MOMA too

@stelmo
Copy link
Collaborator Author

stelmo commented Feb 20, 2023

and also for pFBA in general

@stelmo stelmo added the do not merge When a PR is labelled as such, do not merge label Feb 20, 2023
@exaexa exaexa self-assigned this Feb 27, 2023
Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok now we have wrapper architecture nicely split off and there's the "generic" QP objective wrappers. I guess pFBA can be done over these as well, right?

Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awright

@exaexa exaexa merged commit 10b0a29 into next Mar 5, 2023
@exaexa exaexa deleted the mo-pfba-pipe branch March 5, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge When a PR is labelled as such, do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants