-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pFBA pipe #747
pFBA pipe #747
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## next #747 +/- ##
==========================================
+ Coverage 88.30% 88.63% +0.33%
==========================================
Files 90 89 -1
Lines 2248 2262 +14
==========================================
+ Hits 1985 2005 +20
+ Misses 263 257 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/format |
✔️ Auto-formatting triggered by this comment succeeded, commited as dabbe84 |
/format |
✔️ Auto-formatting triggered by this comment succeeded, commited as f916bfb |
NOTE: variables are not the semantic variables! |
this poses problems for MOMA too |
and also for pFBA in general |
unify L2-like QP handling
split wrappers off to a separate module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok now we have wrapper architecture nicely split off and there's the "generic" QP objective wrappers. I guess pFBA can be done over these as well, right?
implement wrappy pFBA using the normal L2 wrappers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awright
Adds a basic pipe-able pFBA variant. Should play nicely with more interesting model types, e.g. enzyme constrained etc.
@exaexa what do you think?