Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipes to all the analysis functions #751

Closed
wants to merge 1 commit into from
Closed

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented Feb 13, 2023

I want this to be a reality:

model |> with_changed_bounds(...) |> with_added_reaction(...) |> with_enzyme_constraints(...) |> flux_balance_analysis(...) |> to_dict(:enzymes)

@stelmo
Copy link
Collaborator Author

stelmo commented Feb 13, 2023

Related to #747

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 88.79% // Head: 88.62% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (773dfda) compared to base (61b2d8c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #751      +/-   ##
==========================================
- Coverage   88.79%   88.62%   -0.17%     
==========================================
  Files          88       88              
  Lines        2097     2101       +4     
==========================================
  Hits         1862     1862              
- Misses        235      239       +4     
Impacted Files Coverage Δ
src/analysis/flux_balance_analysis.jl 81.81% <0.00%> (-18.19%) ⬇️
src/analysis/parsimonious_flux_balance_analysis.jl 70.83% <0.00%> (-6.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@exaexa
Copy link
Collaborator

exaexa commented Feb 14, 2023

This is good. Do we add the Result overloads here?

@stelmo
Copy link
Collaborator Author

stelmo commented Feb 15, 2023

Yes! I was thinking that each analysis function returns both the input model and the solved jump model (probably wrapped up into a type)

@exaexa exaexa added this to the v2.0 milestone Feb 16, 2023
@stelmo stelmo added the do not merge When a PR is labelled as such, do not merge label Feb 16, 2023
@stelmo stelmo closed this Feb 20, 2023
@stelmo stelmo deleted the mo-pipe-analysis branch January 4, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge When a PR is labelled as such, do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants