-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move most of min_requirements.py to the framework #105
Move most of min_requirements.py to the framework #105
Conversation
The following files are added (imported) from the main Mbed TLS repo: scripts/mbedtls_framework/min_requirements.py Signed-off-by: Valerio Setti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things I am not sure about.
50bdc2e
to
50d4312
Compare
- prevent the file from being called directly from the command line; - allow to pass in the default requirement file so that each repo can specify its own version. Signed-off-by: Valerio Setti <[email protected]>
50d4312
to
a84269f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes approved by the CI of Mbed-TLS/mbedtls#9863, Mbed-TLS/mbedtls#9864 and Mbed-TLS/TF-PSA-Crypto#148. |
Description
Resolves #86
PR checklist
Please add the numbers (or links) of the associated pull requests for consuming branches. You can omit branches where this pull request is not needed.
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.
Help make review efficient: