-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move most of min_requirements.py to the framework #9863
Move most of min_requirements.py to the framework #9863
Conversation
645a9a8
to
07a488d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. While working on min_requirements.py, could you add the *.requirements.txt
files and min_requirements.py in TF-PSA-Crypto. We will need that for TF-PSA-Crypto standalone CI.
b34c370
07a488d
to
b34c370
Compare
Done here Mbed-TLS/TF-PSA-Crypto#148 |
b34c370
to
10c6102
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
22583cf
10c6102
to
22583cf
Compare
Still a framework conflict, you probably need to rebase this PR. |
The following files are moved to the framework repo (deleted here): scripts/min_requirements.py Signed-off-by: Valerio Setti <[email protected]>
This call into the "old" script that has been moved to the framework repository. The *.requirements.txt files are kept on this repo though. Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
22583cf
to
7459ef2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
67ba14c
Description
Resolves Mbed-TLS/mbedtls-framework#105 for the development branch
PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.
Help make review efficient: