Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explorer] All changes from gdc demo #1041

Merged
merged 57 commits into from
Mar 25, 2022
Merged

[explorer] All changes from gdc demo #1041

merged 57 commits into from
Mar 25, 2022

Conversation

stella3d
Copy link
Contributor

All changes under the ./explorer folder on the explorer-rest branch that were made in the run up to GDC.

It is a lot of changes, but picking them apart might be difficult.

The changes to the explorer assume that we have some of the changes to the backend REST api from experimental-rest-api branch, so we want to get that merged in a similar timeframe ideally.

@stella3d stella3d self-assigned this Mar 23, 2022
@apburnie
Copy link
Contributor

When https://demo-rpc.sui.io/objects?address= is applied to an object, the backend responds with [] rather than an error message. I've implemented a block that prevents address results from showing in this case.

If you visit https://explorer-demo.sui.io/objects/4ea58a9788562c53fe11f63e2662401d8312b14d and click the Owner value and then click back you will see the problem this is causing.

@stella3d stella3d requested a review from 666lcz March 25, 2022 02:32
@666lcz
Copy link
Contributor

666lcz commented Mar 25, 2022

Please run

find ./ -name "*.ts" -exec gsed -i -e '1i\/\/ Copyright (c) 2022, Mysten Labs, Inc.\n\/\/ SPDX-License-Identifier: Apache-2.0\n' '{}' \;\n

find ./ -name "*.tsx" -exec gsed -i -e '1i\/\/ Copyright (c) 2022, Mysten Labs, Inc.\n\/\/ SPDX-License-Identifier: Apache-2.0\n' '{}' \;\n

to fix all the license headers, otherwise you will fail this check.

Copy link
Contributor

@666lcz 666lcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to unblock

@stella3d
Copy link
Contributor Author

@666lcz that command doesn't seem to work, always errs with find: gsed: No such file or directory

@666lcz
Copy link
Contributor

666lcz commented Mar 25, 2022

brew install gsed

@apburnie
Copy link
Contributor

I've created a PR here #1070. This fixes some bugs, reinstates a working UI test suite, fixes latency issues and splits the view/fetch logic. It also resolves the above issue with Required statuses must pass before merging. The branch has been rebased on this branch to remove any conflicts

@stella3d stella3d requested a review from Clay-Mysten as a code owner March 25, 2022 20:43
@stella3d stella3d merged commit bca13f6 into main Mar 25, 2022
@stella3d stella3d deleted the explorer-merge branch March 25, 2022 23:00
Copy link
Contributor

@Clay-Mysten Clay-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retroactive thanks to Stella for excellent doc additions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants