-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[explorer] All changes from gdc demo #1041
Conversation
f6e3cb7
to
ebe9991
Compare
When If you visit https://explorer-demo.sui.io/objects/4ea58a9788562c53fe11f63e2662401d8312b14d and click the Owner value and then click back you will see the problem this is causing. |
Please run
to fix all the license headers, otherwise you will fail this check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve to unblock
@666lcz that command doesn't seem to work, always errs with |
|
I've created a PR here #1070. This fixes some bugs, reinstates a working UI test suite, fixes latency issues and splits the view/fetch logic. It also resolves the above issue with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retroactive thanks to Stella for excellent doc additions.
All changes under the
./explorer
folder on theexplorer-rest
branch that were made in the run up to GDC.It is a lot of changes, but picking them apart might be difficult.
The changes to the explorer assume that we have some of the changes to the backend REST api from
experimental-rest-api
branch, so we want to get that merged in a similar timeframe ideally.