Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[explorer] Reinstate test suite, fix latency issues and split view/fetch logic #1070

Merged
merged 70 commits into from
Mar 28, 2022
Merged

[explorer] Reinstate test suite, fix latency issues and split view/fetch logic #1070

merged 70 commits into from
Mar 28, 2022

Conversation

apburnie
Copy link
Contributor

This PR adds the latest changes I've been working on. It will be updated to reflect the latest changes to the explorer-merge branch.

@apburnie apburnie requested a review from stella3d March 25, 2022 09:43
@apburnie
Copy link
Contributor Author

Found and Resolved following bugs:

@apburnie apburnie marked this pull request as ready for review March 25, 2022 14:48
@apburnie apburnie requested review from 666lcz, arun-koshy and oxade March 25, 2022 14:48
@apburnie apburnie mentioned this pull request Mar 25, 2022
Merged
@apburnie
Copy link
Contributor Author

@stella3d --> How is ./explorer/client/src/utils/demoTypes.ts used? I could not find another file that imports this file. Can we remove this file?

@apburnie apburnie changed the title [explorer] Reinstigate test suite, fix latency issues and split view/fetch logic [explorer] Reinstate test suite, fix latency issues and split view/fetch logic Mar 25, 2022
Base automatically changed from explorer-merge to main March 25, 2022 23:00
@stella3d stella3d requested a review from Clay-Mysten as a code owner March 25, 2022 23:00
stella3d
stella3d suggested changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@stella3d stella3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change look good but they don't play nice with the main branch yet - i tried doing a rebase but it got messy.

One we get the merge conflicts sorted out this should be good

Stella Cannefax and others added 20 commits March 28, 2022 13:06
@apburnie
demo_types -> demoTypes
09b6812
@apburnie
prettier changes
9888a50
@apburnie
static transactions data displays only when tests are run
d976220
@apburnie
static address data displays only when tests are run
b28eb14
@apburnie
search says Please Wait while data is loading
2e24dfd
@apburnie
objectId and category being objects have same effect thus rationalized
33b8663
@apburnie
longtext clickable links say Please Wait while data is loading
ddac585
@apburnie
split Object data extraction from view
05b53cf
@apburnie
standardize data fetching for object and address result
2a08337
@apburnie
ObjectResult Types in one place
19d485f
@apburnie
static object data displays only when tests are run
4ddc675
@apburnie
removes warnings from tests
c1191f2
@apburnie
creates placeholder for smart contract data
f63117f
@apburnie
reapply naming convention from explorer-merge
2ec7a04
@apburnie
reapply removal of rpc
f00c309
@apburnie
resolves missing link when clicking through levels of ownership of mo…
c9b0512 
…nster
@apburnie
implements 'No Image was Found' rather than 'Please Wait' when image …
ea0f04e 
…is missing
@apburnie
reintroduce refactoring from explorer-merge
31cac49
@apburnie
comments out CSS code for smart contract display
571654a
@apburnie
updates README to provide guidance
02685d3
@apburnie
Copy link
Contributor Author

@stella3d --> I've rebased this branch on main and resolved the merge conflicts.

Clay-Mysten
Clay-Mysten approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@Clay-Mysten Clay-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one optional suggestion. Thanks, Andrew!

Clay-Mysten
Clay-Mysten approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@Clay-Mysten Clay-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Andrew!

@apburnie apburnie merged commit 59297d6 into main Mar 28, 2022
@apburnie apburnie deleted the explorer-tests branch March 28, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stella3d stella3d stella3d approved these changes

@Clay-Mysten Clay-Mysten Clay-Mysten approved these changes

@666lcz 666lcz Awaiting requested review from 666lcz

@arun-koshy arun-koshy Awaiting requested review from arun-koshy

@oxade oxade Awaiting requested review from oxade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apburnie @stella3d @Clay-Mysten