Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-direnv: 2.4.0 -> 2.5.1 #270305

Merged
merged 1 commit into from
Nov 28, 2023
Merged

nix-direnv: 2.4.0 -> 2.5.1 #270305

merged 1 commit into from
Nov 28, 2023

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Nov 27, 2023 •
edited
Loading

Diff: nix-community/nix-direnv@2.4.0...2.5.1

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@zowoq zowoq requested review from Mic92 and bbenne10 November 27, 2023 00:09
bbenne10
bbenne10 reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@bbenne10 bbenne10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably wait until nix-community/nix-direnv#417 gets merged and released in a new version to avoid a broken version.

@zowoq zowoq marked this pull request as draft November 27, 2023 01:34
@ofborg ofborg bot requested a review from bbenne10 November 27, 2023 07:38
@bbenne10
Copy link
Contributor

nix-community/nix-direnv#419 is now open. That version will likely supersede this PR. Unsure if we should close and re-open, or re-use this existing PR when nix-direnv 3.0.0 (or 2.6.0 if this PR is rejected) is merged and released.

@Mic92
Copy link
Member

Mic92 commented Nov 27, 2023 •
edited
Loading

Just released 2.5.1 to fix the last release. That one should be good to go.

@zowoq zowoq changed the title nix-direnv: 2.4.0 -> 2.5.0 nix-direnv: 2.4.0 -> 2.5.1 Nov 27, 2023
@zowoq zowoq marked this pull request as ready for review November 27, 2023 20:47
bbenne10
bbenne10 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@bbenne10 bbenne10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zowoq zowoq merged commit b586968 into NixOS:master Nov 28, 2023
@zowoq zowoq deleted the nix-direnv branch November 28, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbenne10 bbenne10 bbenne10 approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zowoq @bbenne10 @Mic92