_nix_direnv_watches: update path regex to match capitalized path #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
...I cannot reproduce this. You've fixed this in a backwards compatible way, so I'm happy to merge - but I wonder now why I can't reproduce. The version of direnv I have is only a point release higher (2.32.3), so I wouldn't expect something like this to change? A search of the direnv's issue and pr trackers yield very little. |
|
Ok. This is what does the changing of the serialization format and you'll note that that is included in the that point release. To support everything except the most recent point release, this is 100% a needed change. |
|
Well spotted. I couldn't work it out. |
|
Simply knowing how to use the blame feature in the UI coupled with stumbling onto the right struct in the direnv code. :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small problem with a20b32d. In my environment (direnv 2.32.2) the keys in
DIRENV_WATCHESare capitalized.