-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
awatcher: init at 0.3.0 #287858
awatcher: init at 0.3.0 #287858
Conversation
Squash. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the indentation.
2646815
to
b05e858
Compare
Can you confirm it is correct now? |
Please squash. |
b05e858
to
01ecafc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please set meta.mainProgram
.
01ecafc
to
44a5529
Compare
9688878
to
88b871d
Compare
I didn't see that you had made some revision of the pr, my bad. |
2f81fb6
to
4bd0de8
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4129 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1794 |
Result of 1 package failed to build:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fails to build at the moment.
Logs:
┏━ 1 Errors:
┃ error: builder for '/nix/store/jzgzci4wq56a3hpbl4zlbxjhcdjq1fpc-awatcher-0.2.7.drv' failed with exit code 1;
┃ last 25 log lines:
┃ > > "proc-macro2",
┃ > > "quote",
┃ > 4647,4648c4528,4529
┃ > < "proc-macro2 1.0.82",
┃ > < "quote 1.0.36",
┃ > ---
┃ > > "proc-macro2",
┃ > > "quote",
┃ > 4659,4660c4540,4541
┃ > < "proc-macro2 1.0.82",
┃ > < "quote 1.0.36",
┃ > ---
┃ > > "proc-macro2",
┃ > > "quote",
┃ >
┃ > ERROR: cargoHash or cargoSha256 is out of date
┃ >
┃ > Cargo.lock is not the same in /build/cargo-vendor-dir
┃ >
┃ > To fix the issue:
┃ > 1. Set cargoHash/cargoSha256 to an empty string: `cargoHash = "";`
┃ > 2. Build the derivation and wait for it to fail with a hash mismatch
┃ > 3. Copy the "got: sha256-..." value back into the cargoHash field
┃ > You should have: cargoHash = "sha256-XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX=";
┃ >
┃ For full logs, run 'nix log /nix/store/jzgzci4wq56a3hpbl4zlbxjhcdjq1fpc-awatcher-0.2.7.drv'.
┣━ Dependency Graph:
┃ ⚠ awatcher-0.2.7 failed with exit code 1 after ⏱ 2s in patchPhase
fix: use 'awatcher' as the opposite of the 'pname' variable for the repository name Co-authored-by: Robert Schütz <[email protected]> style: fix indentation Co-authored-by: Robert Schütz <[email protected]> feat: add "awatcher" in "meta.mainProgram" fix: add linux as the unique plataform supported Co-authored-by: Robert Schütz <[email protected]> fix: always build package since it has no extra dependencies Co-authored-by: Sandro <[email protected]> chore: disable package tests as no tests exist
Should be fixed now, at least now in my machine works, I was with the 0.3.0 Cargo.lock while building the 0.2.7 just I just updated to 0.3.0 |
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Closes #287826
Add a 👍 reaction to pull requests you find important.