Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awatcher: init at 0.3.0 #287858

Merged
merged 1 commit into from
Jul 10, 2024
Merged

awatcher: init at 0.3.0 #287858

merged 1 commit into from
Jul 10, 2024

Conversation

aikooo7
Copy link
Contributor

@aikooo7 aikooo7 commented Feb 10, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Closes #287826


Add a 👍 reaction to pull requests you find important.

@aikooo7 aikooo7 requested a review from dotlambda February 11, 2024 00:55
@dotlambda
Copy link
Member

Squash.

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indentation.

@aikooo7
Copy link
Contributor Author

aikooo7 commented Feb 11, 2024

Please fix the indentation.

Can you confirm it is correct now?

@dotlambda
Copy link
Member

Please squash.

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set meta.mainProgram.

@sifmelcara sifmelcara mentioned this pull request Jun 11, 2024
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Jun 11, 2024
@aikooo7 aikooo7 force-pushed the add-awatcher branch 2 times, most recently from 9688878 to 88b871d Compare June 11, 2024 23:03
@aikooo7
Copy link
Contributor Author

aikooo7 commented Jun 11, 2024

I didn't see that you had made some revision of the pr, my bad.

@aikooo7 aikooo7 requested a review from dotlambda June 11, 2024 23:04
@aikooo7 aikooo7 changed the title awatcher: init at 0.2.4 awatcher: init at 0.2.7 Jun 11, 2024
@aikooo7 aikooo7 force-pushed the add-awatcher branch 2 times, most recently from 2f81fb6 to 4bd0de8 Compare June 13, 2024 10:54
@aikooo7 aikooo7 changed the title awatcher: init at 0.2.7 awatcher: init at 0.3.0 Jun 13, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4129

@Guekka Guekka mentioned this pull request Jun 25, 2024
13 tasks
@aikooo7 aikooo7 changed the title awatcher: init at 0.3.0 awatcher: init at 0.2.7 Jun 25, 2024
Copy link
Contributor

@Guekka Guekka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Guekka Guekka added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 25, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1794

@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 287858 run on x86_64-linux 1

1 package failed to build:
  • awatcher

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails to build at the moment.

Logs:

┏━ 1 Errors: 
┃ error: builder for '/nix/store/jzgzci4wq56a3hpbl4zlbxjhcdjq1fpc-awatcher-0.2.7.drv' failed with exit code 1;
┃        last 25 log lines:
┃        > >  "proc-macro2",
┃        > >  "quote",
┃        > 4647,4648c4528,4529
┃        > <  "proc-macro2 1.0.82",
┃        > <  "quote 1.0.36",
┃        > ---
┃        > >  "proc-macro2",
┃        > >  "quote",
┃        > 4659,4660c4540,4541
┃        > <  "proc-macro2 1.0.82",
┃        > <  "quote 1.0.36",
┃        > ---
┃        > >  "proc-macro2",
┃        > >  "quote",
┃        >
┃        > ERROR: cargoHash or cargoSha256 is out of date
┃        >
┃        > Cargo.lock is not the same in /build/cargo-vendor-dir
┃        >
┃        > To fix the issue:
┃        > 1. Set cargoHash/cargoSha256 to an empty string: `cargoHash = "";`
┃        > 2. Build the derivation and wait for it to fail with a hash mismatch
┃        > 3. Copy the "got: sha256-..." value back into the cargoHash field
┃        >    You should have: cargoHash = "sha256-XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX=";
┃        >
┃        For full logs, run 'nix log /nix/store/jzgzci4wq56a3hpbl4zlbxjhcdjq1fpc-awatcher-0.2.7.drv'.
┣━ Dependency Graph:
┃ ⚠ awatcher-0.2.7 failed with exit code 1 after ⏱ 2s in patchPhase

fix: use 'awatcher' as the opposite of the 'pname' variable for the repository name

Co-authored-by: Robert Schütz <[email protected]>

style: fix indentation

Co-authored-by: Robert Schütz <[email protected]>

feat: add "awatcher" in "meta.mainProgram"

fix: add linux as the unique plataform supported

Co-authored-by: Robert Schütz <[email protected]>

fix: always build package since it has no extra dependencies

Co-authored-by: Sandro <[email protected]>

chore: disable package tests as no tests exist
@aikooo7 aikooo7 changed the title awatcher: init at 0.2.7 awatcher: init at 0.3.0 Jul 10, 2024
@aikooo7 aikooo7 requested a review from JohnRTitor July 10, 2024 12:18
@aikooo7
Copy link
Contributor Author

aikooo7 commented Jul 10, 2024

Fails to build at the moment.

Logs:

Should be fixed now, at least now in my machine works, I was with the 0.3.0 Cargo.lock while building the 0.2.7 just I just updated to 0.3.0

@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 287858 run on x86_64-linux 1

1 package built:
  • awatcher

@JohnRTitor JohnRTitor dismissed their stale review July 10, 2024 16:16

changes addressed

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnRTitor JohnRTitor merged commit e7c636b into NixOS:master Jul 10, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: awatcher
6 participants