-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aw-awatcher: init at 0.2.7 #315864
aw-awatcher: init at 0.2.7 #315864
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4066 |
a55155f
to
e52c007
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me, thanks
license = lib.licenses.mpl20; | ||
maintainers = with lib.maintainers; [ bhasher ]; | ||
mainProgram = "awatcher"; | ||
platforms = lib.platforms.linux; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
am not sure if we need to mark it as broken on darwin
if we already exclude it here. but specifying linux
as the only supported platform, should be enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be in a separate commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can split it if it's necessary
My bad for being so much time out first of all. I had indeed some stuff to do in that pr that I didn't see, my bad. Everything should be fixed now and now I am also using the latest version. |
Feel free to merge the other PR, but it seems stale and was several versions behind. It also include the |
|
Yup, it's perfect now, my comment was anterior to that change.
I can agree with you and did that at first, but I changed due to a comment. To be honest I don't really care which PR is merged, but I would love to see this package in |
Closed in favor of #287858, which is now more up to date. |
Description of changes
https://github.com/2e3s/awatcher
Activity and idle watchers for activitywatch compatible with wayland and hyprland.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.