[14.0][l10n_br_account][IMP] composite account.move #2761

rvalyi · 2023-10-28T21:51:40Z

A single account.move can now eventually have different l10n_br_fiscal.document from its invoice_line_ids. This can be useful to import several CTe's or several NFSe's under the same account.move as these fiscal document allow only 1 item line and as this is usually done in other ERP's. At least we are reusing the _onchange_fiscal_document_line_id from this feature to properly complete the account.move.line with their proper onchanges.

This PR is used in the NFe importation PR #2781

OCA-git-bot · 2023-10-28T21:52:07Z

Hi @renatonlima,
some modules you are maintaining are being modified, check this out!

felipemotter · 2024-03-17T20:32:26Z

Como ta a situação dessa proposta @rvalyi ? Já da pra testar de forma concreta?

rvalyi · 2024-03-17T21:44:06Z

Como ta a situação dessa proposta @rvalyi ? Já da pra testar de forma concreta?

vou subir uns testes em breve...

rvalyi · 2024-03-21T10:51:17Z

@felipemotter @antoniospneto @marcelsavegnago @renatonlima @mbcosta @mileo

The PR is ready now for review now. I made e few changes and added a complete test suite (it's inside the test_account_move_lc.py file to avoid loading a fake chart of account another time, which would make the tests much slower).

As you can see, I added the fiscal_document_ids computed field with proper comments. Some extra checks are added in the case the user tries to perform an action on a move with several different fiscal documents.

Especially the fiscal view button now open the list of the related fiscal documents in the case there are more than 1.
For this, I changed the menu so there is now an "all low level Fiscal Documents" menu and action that will open the l10n_br_fiscal.document even when the l10n_br_account module is installed. This will also be useful to better track the webservice communication as pointed by @renatonlima and @antoniospneto.

Also now, in the UI, you can either:

create a new invoice line and select an existing fiscal document line to import it (the line will be populated with the onchange event):
or you can also import all the lines and other fiscal information from an existing l10n_br_fiscal.document right from the account.move form:

@felipemotter @antoniospneto you could probably use that to merge several CTe's into the same bill for instance. cc @douglascstd . Mileo you were also concerned with the need for such a feature for the NFSe's a few years ago...

Just to be clear: I could have made the NFe importation (#2781) work without this, but it would give me almost 2x more work as these two PRs share many concerns.

rvalyi · 2024-03-21T13:35:49Z

Eu atualizei o PR de importação da NFe com esses 4 commits #2781 (comment)

antoniospneto · 2024-03-21T13:57:04Z

l10n_br_account/models/account_move_line.py

+            if values.get("fiscal_document_line_id"):
+                fiscal_line_data = (
+                    self.env["l10n_br_fiscal.document.line"]
+                    .browse(values["fiscal_document_line_id"])
+                    .read(self._shadowed_fields())[0]
+                )
+                for k, v in fiscal_line_data.items():
+                    if isinstance(v, tuple):  # m2o
+                        values[k] = v[0]
+                    else:
+                        values[k] = v
+                continue


@rvalyi eu não certerza se compreendi bem aqui, aqui você faz o inverso do que é feito _inject_shadowed_fields() ?
ao invés de sincronizar o fiscal_line com o move_line, vc tá sincronizando o move_line com o fiscal_line isso ?

eh isso sim. Nos testes desse PR eu testo isso de forma um pouco superficial, mas se vc testa de importar uma NFe em #2781 vai testar isso de forma bem funda. Inclusive eu penso botar outros testes depois em #2781 antes do merge...

Ai pelo sistema do _inherits a sincronização acontece de forma natural pelo framework (ou seja o account.move.line vai puxar os valoras fiscais da linha de documento fiscal pelo _inherits).
Os únicos campos que a gente tem que lidar são aqueles que são "shadowed" ou seja que não vão ser herdado mas que precisam ser duplicados no account.move.line. Esse código lida com essa copia desses 4 ou 5 campos.

felipemotter · 2024-03-21T17:40:26Z

Irei revisar logo.

rvalyi · 2024-03-25T17:49:48Z

@mileo não era isso que vc precisava aqui na sua RFC #894 ?
ai que tal testar...

mileo · 2024-03-25T18:05:43Z

@mileo não era isso que vc precisava aqui na sua RFC #894 ? ai que tal testar...

Sim, sobrando um tempo essa semana eu vou testar. Isso tem que fazer com bastante calma, mas é uma ótima contribuição, vai ajudar na questão do CT-e e outros documentos.

mileo · 2024-03-29T16:49:04Z

@rvalyi pode fazer um rebase?

rvalyi · 2024-03-29T16:54:15Z

@rvalyi pode fazer um rebase?

feito.
CUIDADO se for fazer merge depois tem que ser com nobump.

mileo

LGTM, do ponto de vista financeiro depois será necessário pensar em algumas melhorias, caso somente umas das linhas tenha sido cancelada.

Seja removendo a linha ou dividindo o documento em dois, só com a parte não cancelada.
Ou inserindo uma linha negativa para abater o valor.
Ou até um reembolso da parte cancelada.

rvalyi · 2024-03-29T18:23:13Z

a ideia é meio que definir uma "topologia" que funciona e que não conflita com a importação dos documentos fiscais (a NFe no caso). Depois da sim para melhorar muitas coisas em volta disso. Inclusive, vale a pena vc pensar bem se quer continuar fazer a NFSe como vc fez hoje somando todas linhas na mesma NFSe, pois poderia fazer uma NFSe por linha tb.

marcelsavegnago · 2024-04-17T11:31:31Z

@rvalyi pode dar um rebase por favor ?

rvalyi · 2024-04-17T18:12:32Z

@rvalyi pode dar um rebase por favor ?

feito

marcelsavegnago

LGTM

OCA-git-bot · 2024-04-19T13:36:57Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rvalyi · 2024-04-19T13:44:03Z

/ocabot merge nobump

OCA-git-bot · 2024-04-19T13:44:10Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-2761-by-rvalyi-bump-nobump, awaiting test results.

OCA-git-bot · 2024-04-19T14:17:59Z

Congratulations, your PR was merged at ee37297. Thanks a lot for contributing to OCA. ❤️

rvalyi marked this pull request as draft October 28, 2023 21:51

rvalyi force-pushed the 14.0-composite-move branch from 044cae8 to 2528ed5 Compare October 28, 2023 21:57

rvalyi force-pushed the 14.0-composite-move branch from 2528ed5 to 68f3b59 Compare March 4, 2024 21:43

rvalyi mentioned this pull request Mar 4, 2024

[14.0][l10n_br_fiscal][l10n_br_nfe][l10n_br_account][l10n_br_account_nfe] importação dos account.move com as NFe's - contra-proposta #2781

Open

9 tasks

rvalyi mentioned this pull request Mar 13, 2024

Emissão de NF's não vinculadas às Faturas (Industrialização, Remessa p Conserto etc.) #2956

Closed

rvalyi force-pushed the 14.0-composite-move branch 2 times, most recently from 184f8d9 to 43e6c91 Compare March 17, 2024 15:15

rvalyi force-pushed the 14.0-composite-move branch 4 times, most recently from 337ecd8 to 74f9560 Compare March 21, 2024 10:31

rvalyi marked this pull request as ready for review March 21, 2024 10:51

rvalyi mentioned this pull request Mar 21, 2024

[15.0][l10n_br_account][IMP] composite account.move; forward port de #2761 #2962

Merged

antoniospneto reviewed Mar 21, 2024

View reviewed changes

rvalyi mentioned this pull request Mar 25, 2024

[RFC] Permitir a criação de múltiplos documentos fiscais a partir de uma invoice. #894

Closed

rvalyi force-pushed the 14.0-composite-move branch from 74f9560 to 9638520 Compare March 28, 2024 17:45

rvalyi force-pushed the 14.0-composite-move branch from 9638520 to b216bd2 Compare March 29, 2024 16:53

mileo approved these changes Mar 29, 2024

View reviewed changes

mileo requested review from antoniospneto and marcelsavegnago March 29, 2024 17:48

mileo mentioned this pull request Apr 3, 2024

[14.0][WIP] Importação de Documentos Fiscais, Integração com Compras e Estoque #2994

Closed

rvalyi mentioned this pull request Apr 4, 2024

[14.0][RFC] l10n_br_account: refactor create_wh_invoice process #2997

Closed

marcelsavegnago requested a review from douglascstd April 16, 2024 15:14

rvalyi force-pushed the 14.0-composite-move branch from b216bd2 to e8bc9bd Compare April 17, 2024 17:56

rvalyi added 4 commits April 18, 2024 15:36

[REF] some cosmetic var renames

03ade66

[REF] All low level Documents menu

f8ba63c

[REF] all documents (account.move) menu

b5ec8f7

[IMP] composite account.move

09893ef

rvalyi force-pushed the 14.0-composite-move branch from e8bc9bd to 09893ef Compare April 18, 2024 18:37

marcelsavegnago approved these changes Apr 19, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 19, 2024

OCA-git-bot added the bot is merging ⏳ label Apr 19, 2024

OCA-git-bot merged commit 99b780e into OCA:14.0 Apr 19, 2024
5 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 19, 2024

rvalyi mentioned this pull request Apr 22, 2024

[14.0][l10n_br_fiscal][l10n_br_account] mail thread e message_post #3032

Merged

marcelsavegnago mentioned this pull request Apr 25, 2024

[16.0][l10n_br_fiscal][IMP] composite account.move; forward port de #2761 #3054

Merged

This was referenced May 21, 2024

[14.0][FIX] l10n_br_account: account move on fiscal wiz #3090

Merged

[14.0][FIX] l10n_br_account: validate move on document #3093

Merged

rvalyi mentioned this pull request Sep 13, 2024

[14.0][FIX] l10n_br_account: fix account.move post when there is no fiscal document #3364

Merged

rvalyi mentioned this pull request Oct 8, 2024

Boleto unico para multiplas faturas #2658

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][l10n_br_account][IMP] composite account.move #2761

[14.0][l10n_br_account][IMP] composite account.move #2761

rvalyi commented Oct 28, 2023 •

edited

Loading

OCA-git-bot commented Oct 28, 2023

felipemotter commented Mar 17, 2024 •

edited

Loading

rvalyi commented Mar 17, 2024

rvalyi commented Mar 21, 2024 •

edited

Loading

rvalyi commented Mar 21, 2024

antoniospneto Mar 21, 2024

rvalyi Mar 21, 2024 •

edited

Loading

felipemotter commented Mar 21, 2024

rvalyi commented Mar 25, 2024

mileo commented Mar 25, 2024

mileo commented Mar 29, 2024

rvalyi commented Mar 29, 2024

mileo left a comment •

edited

Loading

rvalyi commented Mar 29, 2024

marcelsavegnago commented Apr 17, 2024

rvalyi commented Apr 17, 2024

marcelsavegnago left a comment

OCA-git-bot commented Apr 19, 2024

rvalyi commented Apr 19, 2024

OCA-git-bot commented Apr 19, 2024

OCA-git-bot commented Apr 19, 2024

[14.0][l10n_br_account][IMP] composite account.move #2761

[14.0][l10n_br_account][IMP] composite account.move #2761

Conversation

rvalyi commented Oct 28, 2023 • edited Loading

OCA-git-bot commented Oct 28, 2023

felipemotter commented Mar 17, 2024 • edited Loading

rvalyi commented Mar 17, 2024

rvalyi commented Mar 21, 2024 • edited Loading

rvalyi commented Mar 21, 2024

antoniospneto Mar 21, 2024

Choose a reason for hiding this comment

rvalyi Mar 21, 2024 • edited Loading

Choose a reason for hiding this comment

felipemotter commented Mar 21, 2024

rvalyi commented Mar 25, 2024

mileo commented Mar 25, 2024

mileo commented Mar 29, 2024

rvalyi commented Mar 29, 2024

mileo left a comment • edited Loading

Choose a reason for hiding this comment

rvalyi commented Mar 29, 2024

marcelsavegnago commented Apr 17, 2024

rvalyi commented Apr 17, 2024

marcelsavegnago left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Apr 19, 2024

rvalyi commented Apr 19, 2024

OCA-git-bot commented Apr 19, 2024

OCA-git-bot commented Apr 19, 2024

rvalyi commented Oct 28, 2023 •

edited

Loading

felipemotter commented Mar 17, 2024 •

edited

Loading

rvalyi commented Mar 21, 2024 •

edited

Loading

rvalyi Mar 21, 2024 •

edited

Loading

mileo left a comment •

edited

Loading