[14.0][l10n_br_fiscal][l10n_br_account] mail thread e message_post #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @renatonlima, |
rvalyi
force-pushed
the
14.0-mail-thread
branch
from
7c7c8c4 to
bc7a012
Compare
rvalyi
changed the title
marcelsavegnago
requested review from
antoniospneto,
mileo,
kaynnan and
WesleyOliveira98
kaynnan
approved these changes
Apr 23, 2024
mileo
approved these changes
Apr 24, 2024
|
/ocabot merge minor |
|
On my way to merge this fine PR! |
OCA-git-bot
added a commit
that referenced
this pull request
Apr 24, 2024
|
It looks like something changed on |
|
Congratulations, your PR was merged at c826979. Thanks a lot for contributing to OCA. ❤️ |
This was referenced Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lá no inicio da v12 o l10n_br_fiscal.document herdava do mail.thread e eu acabei tirando alegando que pela herança do account.move não era preciso...
Até que na verdade é desejável sim: agora que implementamos a possibilidade de encaixar vários documentos fiscais num mesmo account.move, é desejável que cada documento fiscal tenha o mail.thread dele. Mas eu implementei um sistema onde cada vez que é postado algo no chatter de um documento fiscal, o message_post acontece tambem para todos account.move relacionados, de forma que continua possível seguir o historico de cada documento fiscal a partir do chatter dos account.move relacionados.
Essa ideia tinha sido me passado pelo
Akim Juillerat da C2C no ano passado: https://twitter.com/akim_c2c/status/1671934029946404964
A vantagem desse design vai ficar mais clara em outros PRs a seguir...