Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PaywallFooterView listeners #1012

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Add PaywallFooterView listeners #1012

merged 2 commits into from
Mar 14, 2024

Conversation

tonidero
Copy link
Contributor

@tonidero tonidero commented Mar 8, 2024

This PR adds initial listeners to the PaywallFooterView. Follow up from #995

@tonidero tonidero added the pr:feat A new feature label Mar 8, 2024
@tonidero tonidero force-pushed the add-listeners-paywall-footer branch from 722560e to 556f2a3 Compare March 13, 2024 14:05
@tonidero tonidero force-pushed the add-listeners-paywall-footer branch from 556f2a3 to 9ba92e7 Compare March 13, 2024 14:14
@@ -32,7 +33,7 @@ internal class PaywallFooterView(
override fun dispose() {}

init {
methodChannel = MethodChannel(messenger, "purchases_ui_flutter/PaywallFooterView/${id}")
methodChannel = MethodChannel(messenger, "com.revenuecat.purchasesui/PaywallFooterView/${id}")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the channel name to be consistent with the full screen version

@tonidero tonidero marked this pull request as ready for review March 13, 2024 14:19
@tonidero tonidero requested review from a team March 13, 2024 14:19
Copy link
Contributor

@vegaro vegaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all that cleanup!

/// been granted in case no relevant purchases were found.
///
/// [onRestoreError] (Optional) Callback that gets called when a restore
/// fails.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding these!

import 'package:purchases_flutter/models/purchases_error.dart';
import 'package:purchases_flutter/models/store_transaction.dart';

class PaywallViewMethodHandler {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so clean!

@tonidero tonidero merged commit 9b01e0d into main Mar 14, 2024
8 checks passed
@tonidero tonidero deleted the add-listeners-paywall-footer branch March 14, 2024 08:38
tonidero added a commit that referenced this pull request Mar 14, 2024
**This is an automatic release.**

### New Features
* Add `onDismiss` handler and `displayCloseButton` to `PaywallView` and
`PaywallFooterView` (#1009) via Toni Rico (@tonidero)
* Add `PaywallFooterView` listeners (#1012) via Toni Rico (@tonidero)
* Add `PaywallView` listeners (#995) via Cesar de la Vega (@vegaro)
### Bugfixes
* Fix footer sizing issues in iOS (#1018) via Toni Rico (@tonidero)
### Dependency Updates
* [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.2.0 (#1020) via
RevenueCat Git Bot (@RCGitBot)
* [Android
7.7.2](https://github.com/RevenueCat/purchases-android/releases/tag/7.7.2)
* [iOS
4.39.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.39.0)
* [iOS
4.38.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.1)
* [iOS
4.38.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.0)
* [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.1.0 (#1013) via
RevenueCat Git Bot (@RCGitBot)
* [Android
7.7.2](https://github.com/RevenueCat/purchases-android/releases/tag/7.7.2)
* [iOS
4.39.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.39.0)
* [iOS
4.38.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.1)
* [iOS
4.38.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.0)
### Other Changes
* Add 5.8.2 to changelog (#1011) via Cesar de la Vega (@vegaro)
* Add dependency_overrides to purchases_flutter_ui (#1007) via Cesar de
la Vega (@vegaro)

---------

Co-authored-by: Toni Rico <[email protected]>
Jethro87 pushed a commit to Jethro87/purchases-flutter that referenced this pull request Jan 4, 2025
This PR adds initial listeners to the `PaywallFooterView`. Follow up
from RevenueCat#995
Jethro87 pushed a commit to Jethro87/purchases-flutter that referenced this pull request Jan 4, 2025
**This is an automatic release.**

### New Features
* Add `onDismiss` handler and `displayCloseButton` to `PaywallView` and
`PaywallFooterView` (RevenueCat#1009) via Toni Rico (@tonidero)
* Add `PaywallFooterView` listeners (RevenueCat#1012) via Toni Rico (@tonidero)
* Add `PaywallView` listeners (RevenueCat#995) via Cesar de la Vega (@vegaro)
### Bugfixes
* Fix footer sizing issues in iOS (RevenueCat#1018) via Toni Rico (@tonidero)
### Dependency Updates
* [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.2.0 (RevenueCat#1020) via
RevenueCat Git Bot (@RCGitBot)
* [Android
7.7.2](https://github.com/RevenueCat/purchases-android/releases/tag/7.7.2)
* [iOS
4.39.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.39.0)
* [iOS
4.38.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.1)
* [iOS
4.38.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.0)
* [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.1.0 (RevenueCat#1013) via
RevenueCat Git Bot (@RCGitBot)
* [Android
7.7.2](https://github.com/RevenueCat/purchases-android/releases/tag/7.7.2)
* [iOS
4.39.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.39.0)
* [iOS
4.38.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.1)
* [iOS
4.38.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.0)
### Other Changes
* Add 5.8.2 to changelog (RevenueCat#1011) via Cesar de la Vega (@vegaro)
* Add dependency_overrides to purchases_flutter_ui (RevenueCat#1007) via Cesar de
la Vega (@vegaro)

---------

Co-authored-by: Toni Rico <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants