Add `PaywallView` listeners #995

vegaro · 2024-02-29T19:48:16Z

Added listeners that can be used like:

return Scaffold(
      body: Center(
        child: PaywallView(
          onPurchaseStarted: (Package rcPackage) {
            print('Purchase started for package: ${rcPackage.identifier}');
          },
          onPurchaseCompleted:
              (CustomerInfo customerInfo, StoreTransaction storeTransaction) {
            print('Purchase completed for customerInfo:\n $customerInfo\n '
                'and storeTransaction:\n $storeTransaction');
          },
          onPurchaseError: (PurchasesError error) {
            print('Purchase error: $error');
          },
          onRestoreCompleted: (CustomerInfo customerInfo) {
            print('Restore completed for customerInfo:\n $customerInfo');
          },
          onRestoreError: (PurchasesError error) {
            print('Restore error: $error');
          },
        ),
      ),
    );

tonidero

Nice! Left a few comments about some missing listeners, but I think we can add those in a different PR as well

tonidero · 2024-03-07T09:37:05Z

..._ui_flutter/android/src/main/kotlin/com/revenuecat/purchases_ui_flutter/views/PaywallView.kt

+                methodChannel.invokeMethod("onPurchaseError", error)
+            }
+
+            override fun onRestoreCompleted(customerInfo: Map<String, Any?>) {


Can we add onRestoreStarted as well?

tonidero · 2024-03-07T09:38:06Z

..._ui_flutter/android/src/main/kotlin/com/revenuecat/purchases_ui_flutter/views/PaywallView.kt

+                )
+            }
+
+            override fun onPurchaseError(error: Map<String, Any?>) {


In RN, we split the onPurchaseCancelled callback. Not sure if we want to do the same here?

..._ui_flutter/android/src/main/kotlin/com/revenuecat/purchases_ui_flutter/views/PaywallView.kt

tonidero · 2024-03-07T09:43:16Z

revenuecat_examples/purchase_tester/lib/src/paywall.dart

-        child: Center(
-          child: PaywallView(offering: widget.offering,),
+        body: SafeArea(
+      child: Center(


The indentation here seems wrong?

vegaro · 2024-03-07T14:53:06Z

going to merge this for the sake of shipping, and will add more in other PRs

I wasn't sure what was going on in #995 but there was some issues importing a newly added model. The problem is that we were depending on version ^6.0.0 of purchases_flutter. I made some changes to the pubspec.yaml, so now we use the local plugin. According to [the docs](https://dart.dev/tools/pub/dependencies), "As a result, if you publish a package to pub.dev, keep in mind that your package's dependency overrides are ignored by all users of your package.". So we should be fine to publish it like this.

…-functions-to-full-screen

This PR adds initial listeners to the `PaywallFooterView`. Follow up from #995

@tonidero

**This is an automatic release.** ### New Features * Add `onDismiss` handler and `displayCloseButton` to `PaywallView` and `PaywallFooterView` (#1009) via Toni Rico (@tonidero) * Add `PaywallFooterView` listeners (#1012) via Toni Rico (@tonidero) * Add `PaywallView` listeners (#995) via Cesar de la Vega (@vegaro) ### Bugfixes * Fix footer sizing issues in iOS (#1018) via Toni Rico (@tonidero) ### Dependency Updates * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.2.0 (#1020) via RevenueCat Git Bot (@RCGitBot) * [Android 7.7.2](https://github.com/RevenueCat/purchases-android/releases/tag/7.7.2) * [iOS 4.39.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.39.0) * [iOS 4.38.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.1) * [iOS 4.38.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.0) * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.1.0 (#1013) via RevenueCat Git Bot (@RCGitBot) * [Android 7.7.2](https://github.com/RevenueCat/purchases-android/releases/tag/7.7.2) * [iOS 4.39.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.39.0) * [iOS 4.38.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.1) * [iOS 4.38.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.0) ### Other Changes * Add 5.8.2 to changelog (#1011) via Cesar de la Vega (@vegaro) * Add dependency_overrides to purchases_flutter_ui (#1007) via Cesar de la Vega (@vegaro) --------- Co-authored-by: Toni Rico <[email protected]>

I wasn't sure what was going on in RevenueCat#995 but there was some issues importing a newly added model. The problem is that we were depending on version ^6.0.0 of purchases_flutter. I made some changes to the pubspec.yaml, so now we use the local plugin. According to [the docs](https://dart.dev/tools/pub/dependencies), "As a result, if you publish a package to pub.dev, keep in mind that your package's dependency overrides are ignored by all users of your package.". So we should be fine to publish it like this.

Added listeners that can be used like: ``` return Scaffold( body: Center( child: PaywallView( onPurchaseStarted: (Package rcPackage) { print('Purchase started for package: ${rcPackage.identifier}'); }, onPurchaseCompleted: (CustomerInfo customerInfo, StoreTransaction storeTransaction) { print('Purchase completed for customerInfo:\n $customerInfo\n ' 'and storeTransaction:\n $storeTransaction'); }, onPurchaseError: (PurchasesError error) { print('Purchase error: $error'); }, onRestoreCompleted: (CustomerInfo customerInfo) { print('Restore completed for customerInfo:\n $customerInfo'); }, onRestoreError: (PurchasesError error) { print('Restore error: $error'); }, ), ), ); ```

This PR adds initial listeners to the `PaywallFooterView`. Follow up from RevenueCat#995

@tonidero

**This is an automatic release.** ### New Features * Add `onDismiss` handler and `displayCloseButton` to `PaywallView` and `PaywallFooterView` (RevenueCat#1009) via Toni Rico (@tonidero) * Add `PaywallFooterView` listeners (RevenueCat#1012) via Toni Rico (@tonidero) * Add `PaywallView` listeners (RevenueCat#995) via Cesar de la Vega (@vegaro) ### Bugfixes * Fix footer sizing issues in iOS (RevenueCat#1018) via Toni Rico (@tonidero) ### Dependency Updates * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.2.0 (RevenueCat#1020) via RevenueCat Git Bot (@RCGitBot) * [Android 7.7.2](https://github.com/RevenueCat/purchases-android/releases/tag/7.7.2) * [iOS 4.39.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.39.0) * [iOS 4.38.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.1) * [iOS 4.38.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.0) * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.1.0 (RevenueCat#1013) via RevenueCat Git Bot (@RCGitBot) * [Android 7.7.2](https://github.com/RevenueCat/purchases-android/releases/tag/7.7.2) * [iOS 4.39.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.39.0) * [iOS 4.38.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.1) * [iOS 4.38.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.0) ### Other Changes * Add 5.8.2 to changelog (RevenueCat#1011) via Cesar de la Vega (@vegaro) * Add dependency_overrides to purchases_flutter_ui (RevenueCat#1007) via Cesar de la Vega (@vegaro) --------- Co-authored-by: Toni Rico <[email protected]>

vegaro added the pr:feat A new feature label Feb 29, 2024

vegaro force-pushed the sdk-3339-add-listener-functions-to-full-screen branch 2 times, most recently from 608ae03 to b9696b4 Compare March 6, 2024 18:29

vegaro added 5 commits March 6, 2024 19:37

add purchases_error

f4dcb29

add ios implementation

2715381

add android implementation

fa1e8cd

add dart implementation

537f366

add to sample

f647a3f

vegaro force-pushed the sdk-3339-add-listener-functions-to-full-screen branch from efc9e1d to f647a3f Compare March 6, 2024 18:39

vegaro marked this pull request as ready for review March 6, 2024 18:40

vegaro requested a review from a team March 6, 2024 18:40

tonidero approved these changes Mar 7, 2024

View reviewed changes

vegaro added 3 commits March 7, 2024 15:41

remove todo

3c6b569

add commentson empty channels

238cc3c

fix indentation

d8d0504

vegaro enabled auto-merge (squash) March 7, 2024 14:52

vegaro added 3 commits March 7, 2024 16:19

fix api tests

254806a

fix lint errors

012b333

remove property

d486a31

vegaro mentioned this pull request Mar 7, 2024

Add dependency_overrides to purchases_flutter_ui #1007

Merged

vegaro added 3 commits March 7, 2024 20:09

Merge remote-tracking branch 'origin/main' into sdk-3339-add-listener…

0c0d900

…-functions-to-full-screen

add missing api test

94bb461

fix api test

c489782

vegaro merged commit 7af9858 into main Mar 8, 2024
8 checks passed

vegaro deleted the sdk-3339-add-listener-functions-to-full-screen branch March 8, 2024 09:15

tonidero mentioned this pull request Mar 8, 2024

Add PaywallFooterView listeners #1012

Merged

RCGitBot mentioned this pull request Mar 13, 2024

[AUTOMATIC] Release/6.24.0 #1019

Closed

tonidero added a commit that referenced this pull request Mar 14, 2024

Add PaywallFooterView listeners (#1012)

9b01e0d

This PR adds initial listeners to the `PaywallFooterView`. Follow up from #995

RCGitBot mentioned this pull request Mar 14, 2024

[AUTOMATIC] Release/6.24.0 #1021

Merged

tonidero mentioned this pull request Mar 15, 2024

Add Flutter listeners and displayCloseButton APIs RevenueCat/docs#158

Merged

Jethro87 pushed a commit to Jethro87/purchases-flutter that referenced this pull request Jan 4, 2025

Add PaywallFooterView listeners (RevenueCat#1012)

6259035

This PR adds initial listeners to the `PaywallFooterView`. Follow up from RevenueCat#995

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `PaywallView` listeners #995

Add `PaywallView` listeners #995

vegaro commented Feb 29, 2024 •

edited

Loading

tonidero left a comment

tonidero Mar 7, 2024

tonidero Mar 7, 2024

tonidero Mar 7, 2024

vegaro commented Mar 7, 2024

Add PaywallView listeners #995

Add PaywallView listeners #995

Conversation

vegaro commented Feb 29, 2024 • edited Loading

tonidero left a comment

Choose a reason for hiding this comment

tonidero Mar 7, 2024

Choose a reason for hiding this comment

tonidero Mar 7, 2024

Choose a reason for hiding this comment

tonidero Mar 7, 2024

Choose a reason for hiding this comment

vegaro commented Mar 7, 2024

Add `PaywallView` listeners #995

Add `PaywallView` listeners #995

vegaro commented Feb 29, 2024 •

edited

Loading