Release 1.4.3 #128
Release 1.4.3 #128
Conversation
…chases target correctly in flutter projects.
| s.pod_target_xcconfig = { | ||
| 'DEFINES_MODULE' => 'YES', | ||
| 'EXCLUDED_ARCHS[sdk=iphonesimulator*]' => 'i386', | ||
| 'OTHER_LDFLAGS' => '-framework Purchases' |
There was a problem hiding this comment.
this line is the actual fix. it adds a missing linker flag that links the Purchases framework.
I'm not sure why this flag isn't added automatically, I'm still figuring that out. But it did fix the linker issues on the test project I'm using
| @@ -539,7 +539,7 @@ | |||
| }; | |||
| 97C147071CF9000F007C117D /* Release */ = { | |||
| isa = XCBuildConfiguration; | |||
| baseConfigurationReference = 2FBF59F345E05927E16F325B /* Pods-Runner.release.xcconfig */; | |||
| baseConfigurationReference = 7AFA3C8E1D35360C0083082E /* Release.xcconfig */; | |||
There was a problem hiding this comment.
Any idea why this changed? It's just the example but just curious
There was a problem hiding this comment.
I should have added a comment, my bad.
This is a revert of a misguided update from the previous PR: https://github.com/RevenueCat/purchases-flutter/pull/127/files
Turns out that when you manually pod install, you get a warning from cocoapods, so I made the change on the previous pr to fix it...
But the warning was wrong.
Essentially the warning is cocoapods saying "you should be using the xcconfig from cocoapods", but the ones generated by flutter already include the ones in cocoapods.
* fixed xcconfig files mapping * explicitly added s.framework = 'Purchases' so cocoapods links the Purchases target correctly in flutter projects. * bumped version number to 1.4.3 * moved from framework to ldflag * updated changelog * clean up pod_target_xcconfig
1.4.3
Purchasesframework to podspec's linker flags so it gets correctly linked in the plugin pod.Fixed mapping of xcconfig files in Runner example.
Release 1.4.3 #128