Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.4.3 #128

Merged
merged 6 commits into from
Nov 4, 2020
Merged

Release 1.4.3 #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1587508
fixed xcconfig files mapping
aboedo Nov 4, 2020
4ce3660
explicitly added s.framework = 'Purchases' so cocoapods links the Pur…
aboedo Nov 4, 2020
fe4b10f
bumped version number to 1.4.3
aboedo Nov 4, 2020
ee1eb9e
moved from framework to ldflag
aboedo Nov 4, 2020
463c898
updated changelog
aboedo Nov 4, 2020
da45c42
clean up pod_target_xcconfig
aboedo Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 1.4.3

- Explicitly added `Purchases` framework to podspec's linker flags so it gets correctly linked in the plugin pod.
Fixed mapping of xcconfig files in Runner example.
https://github.com/RevenueCat/purchases-flutter/pull/128

## 1.4.2

- Moved from valid architectures to excluded architectures in the Podfile, following Flutter's example.
Expand Down
1 change: 1 addition & 0 deletions VERSIONS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
| Version | iOS version | Android version | Common files version |
|---------|-------------|-----------------|----------------------|
| 1.4.3 | 3.7.5 | 3.5.2 | 1.4.5 |
| 1.4.2 | 3.7.5 | 3.5.2 | 1.4.5 |
| 1.4.1 | 3.7.5 | 3.5.2 | 1.4.5 |
| 1.4.0 | 3.7.2 | 3.5.2 | 1.4.4 |
Expand Down
2 changes: 1 addition & 1 deletion android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
group 'com.revenuecat.purchases_flutter'
version '1.4.2'
version '1.4.3'

buildscript {
ext.kotlin_version = '1.3.72'
Expand Down
2 changes: 1 addition & 1 deletion android/src/main/java/com/revenuecat/purchases_flutter/PurchasesFlutterPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public class PurchasesFlutterPlugin implements FlutterPlugin, MethodCallHandler,
@Nullable private Activity activity;

private static final String PLATFORM_NAME = "flutter";
private static final String PLUGIN_VERSION = "1.4.2";
private static final String PLUGIN_VERSION = "1.4.3";

/**
* Plugin registration.
Expand Down
4 changes: 2 additions & 2 deletions example/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ PODS:
- Flutter (1.0.0)
- Purchases (3.7.5):
- PurchasesCoreSwift (= 3.7.5)
- purchases_flutter (1.4.2):
- purchases_flutter (1.4.3):
- Flutter
- PurchasesHybridCommon (= 1.4.5)
- PurchasesCoreSwift (3.7.5)
Expand Down Expand Up @@ -34,7 +34,7 @@ SPEC CHECKSUMS:
e2e: 967b9b1fc533b7636a3b7a719f840c27f301fe1f
Flutter: 0e3d915762c693b495b44d77113d4970485de6ec
Purchases: 7ebce9418bc16732c3c3bb4b6ff7e7e397de024e
purchases_flutter: f6840d0fe8517713ba5eb5b5037ee07667226777
purchases_flutter: dba3d321c6de0ce5980fe2de119bc7c379597cbc
PurchasesCoreSwift: 50636e307c1ab76c7a7894a87d042665f2fe0be9
PurchasesHybridCommon: b1dd1c5125ccf99b9e62b5974d0e5145895e8b87

Expand Down
6 changes: 3 additions & 3 deletions example/ios/Runner.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@
};
249021D4217E4FDB00AE95B9 /* Profile */ = {
isa = XCBuildConfiguration;
baseConfigurationReference = 137B7D1CB2E55EA7D50EDB57 /* Pods-Runner.profile.xcconfig */;
baseConfigurationReference = 7AFA3C8E1D35360C0083082E /* Release.xcconfig */;
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CLANG_ENABLE_MODULES = YES;
Expand Down Expand Up @@ -507,7 +507,7 @@
};
97C147061CF9000F007C117D /* Debug */ = {
isa = XCBuildConfiguration;
baseConfigurationReference = 2F08CDCFE7CB4096CE881900 /* Pods-Runner.debug.xcconfig */;
baseConfigurationReference = 9740EEB21CF90195004384FC /* Debug.xcconfig */;
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CLANG_ENABLE_MODULES = YES;
Expand Down Expand Up @@ -539,7 +539,7 @@
};
97C147071CF9000F007C117D /* Release */ = {
isa = XCBuildConfiguration;
baseConfigurationReference = 2FBF59F345E05927E16F325B /* Pods-Runner.release.xcconfig */;
baseConfigurationReference = 7AFA3C8E1D35360C0083082E /* Release.xcconfig */;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why this changed? It's just the example but just curious

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have added a comment, my bad.
This is a revert of a misguided update from the previous PR: https://github.com/RevenueCat/purchases-flutter/pull/127/files

Turns out that when you manually pod install, you get a warning from cocoapods, so I made the change on the previous pr to fix it...
But the warning was wrong.
Essentially the warning is cocoapods saying "you should be using the xcconfig from cocoapods", but the ones generated by flutter already include the ones in cocoapods.

buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CLANG_ENABLE_MODULES = YES;
Expand Down
2 changes: 1 addition & 1 deletion example/macos/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ PODS:
- FlutterMacOS (1.0.0)
- Purchases (3.7.5):
- PurchasesCoreSwift (= 3.7.5)
- purchases_flutter (1.4.2):
- purchases_flutter (1.4.3):
- FlutterMacOS
- PurchasesHybridCommon (= 1.4.5)
- PurchasesCoreSwift (3.7.5)
Expand Down
2 changes: 1 addition & 1 deletion ios/Classes/PurchasesFlutterPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ - (NSString *)platformFlavor {
}

- (NSString *)platformFlavorVersion {
return @"1.4.2";
return @"1.4.3";
}

@end
8 changes: 6 additions & 2 deletions ios/purchases_flutter.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#
Pod::Spec.new do |s|
s.name = 'purchases_flutter'
s.version = '1.4.2'
s.version = '1.4.3'
s.summary = 'Cross-platform subscriptions framework for Flutter.'
s.description = <<-DESC
Client for the RevenueCat subscription and purchase tracking system, making implementing in-app subscriptions in Flutter easy - receipt validation and status tracking included!
Expand All @@ -20,7 +20,11 @@ Pod::Spec.new do |s|
s.swift_version = '5.0'

# Flutter.framework does not contain a i386 slice.
s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', 'EXCLUDED_ARCHS[sdk=iphonesimulator*]' => 'i386' }
s.pod_target_xcconfig = {
'DEFINES_MODULE' => 'YES',
'EXCLUDED_ARCHS[sdk=iphonesimulator*]' => 'i386',
'OTHER_LDFLAGS' => '-framework Purchases'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is the actual fix. it adds a missing linker flag that links the Purchases framework.
I'm not sure why this flag isn't added automatically, I'm still figuring that out. But it did fix the linker issues on the test project I'm using

}

end

2 changes: 1 addition & 1 deletion macos/purchases_flutter.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
Pod::Spec.new do |s|
s.name = 'purchases_flutter'
s.version = '1.4.2'
s.version = '1.4.3'
s.summary = 'Cross-platform subscriptions framework for Flutter.'
s.description = <<-DESC
Client for the RevenueCat subscription and purchase tracking system, making implementing in-app subscriptions in Flutter easy - receipt validation and status tracking included!
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: purchases_flutter
description: A Flutter plugin that makes implementing in-app subscriptions for iOS and Android simple – receipt validation and status tracking included!
version: 1.4.2
version: 1.4.3
homepage: https://www.revenuecat.com/
repository: https://github.com/RevenueCat/purchases-flutter
issue_tracker: https://github.com/RevenueCat/purchases-flutter/issues
Expand Down