[NEW] Add gateway proxy setting. #11124
Conversation
|
This change would be welcome also for our company, because we use proxy too, and unfortunately currently we do not use notification. |
|
Is there anything blocking this from merging? |
| @@ -1503,6 +1503,18 @@ RocketChat.settings.addGroup('Push', function() { | |||
| } | |||
| ] | |||
| }); | |||
| this.add('Push_gateway_proxy', '', { | |||
There was a problem hiding this comment.
I wonder if we shouldn't make this more generic. The oembed fetch and a few others also would benefit from a proxy setting
|
A bump. Is there any reason why this hasn't been adopted? There are lots of queries on using Rocket behind corporate Proxies and precious little help for users. I understand this is only for push notifications, and some want to use a Corporate Proxy for all traffic so it may not be a cure all. |
|
@reetp unfortunately this will not be sufficient. :( The gateway will require a token be passed to it, so several other calls will need to go through the proxy as well. Otherwise the gateway will not be able to accept traffic |
Perhaps Rocket ought to make a decision on what to do with Corporate proxies? For better or worse we see a lot of questions on how to push Rocket through a Corporate proxy/cache. I understand it is a complicated scenario, and may be a security nightmare too boot, and not necessarily best practice. There is also very little information on the subject one way or another, with vague hints around about using proxies which causes a lot of confusion. If it is something Rocket doesn't want to officially support it then perhaps some documentation on that fact, along with links to resources where people can read up if they want to support themselves. If it is something Rocket does want to support then it needs documenting accordingly. Just needs a decision ;-) I guess this PR can be closed? |
|
We should document the Meteor's setting for proxy https://github.com/meteor/meteor/wiki/Using-Meteor-behind-a-proxy or create internal settings for a generic proxy configuration. |
We use Rocket Chat in a corporate network and would like to send only push notifications through our proxy. This PR adds a new field in push settings that allows to use a proxy.