Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-publish checks #31

Merged
merged 5 commits into from
Jul 29, 2021
Merged

Add pre-publish checks #31

merged 5 commits into from
Jul 29, 2021

Conversation

shawnbot
Copy link
Member

@shawnbot shawnbot commented Jul 15, 2021

This should help guard against accidentally deleting CSS bundles in the future. This build is an example of what it will look like if we (accidentally or intentionally) remove any of the CSS bundles that we have in there currently.

If we add a new bundle in the future, we should add it to the dist/css/{...}.css glob. If we remove a bundle in the future, we will have to remove it from the same glob to get the checks passing again.

@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-31 July 15, 2021 18:17 Inactive
@shawnbot shawnbot force-pushed the prepublish-checks branch from c96969b to 8c31c06 Compare July 15, 2021 18:17
@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-31 July 15, 2021 18:18 Inactive
@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-31 July 15, 2021 18:22 Inactive
@shawnbot shawnbot marked this pull request as ready for review July 15, 2021 18:25
@shawnbot shawnbot requested a review from aekong July 15, 2021 18:25
@aekong
Copy link
Contributor

aekong commented Jul 15, 2021

hella cool 😍

@shawnbot shawnbot mentioned this pull request Jul 29, 2021
3 tasks
@shawnbot shawnbot force-pushed the prepublish-checks branch from 735cbcb to e319bde Compare July 29, 2021 23:28
@shawnbot shawnbot changed the base branch from main to release-1.3.0 July 29, 2021 23:28
@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-31 July 29, 2021 23:28 Inactive
@shawnbot shawnbot merged commit 8126f28 into release-1.3.0 Jul 29, 2021
@shawnbot shawnbot deleted the prepublish-checks branch July 29, 2021 23:30
shawnbot added a commit that referenced this pull request Jul 29, 2021
* 1.3.0

* add {auto: "auto"} to theme.width (#34)

* Add pre-publish checks (#31)

* install shellcheck

* add scripts/prepublish-checks

* run prepublish checks in CI

* add lint-scripts and prepublishOnly npm scripts

* nix "wut.css" from prepublish checks

* add underline to .btn-link (#36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants