Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.3.0 #35

Merged
merged 4 commits into from
Jul 29, 2021
Merged

Release 1.3.0 #35

merged 4 commits into from
Jul 29, 2021

Conversation

shawnbot
Copy link
Member

@shawnbot shawnbot commented Jul 27, 2021

Pull requests

🚀 Features

🐛 Fixes

🏠 Internal

@shawnbot shawnbot marked this pull request as draft July 27, 2021 20:55
@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-35 July 27, 2021 20:55 Inactive
@shawnbot shawnbot marked this pull request as ready for review July 29, 2021 16:56
@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-35 July 29, 2021 16:56 Inactive
@shawnbot shawnbot requested a review from aekong July 29, 2021 16:56
@shawnbot
Copy link
Member Author

Oh @aekong should we include #31 in this PR too?

@aekong
Copy link
Contributor

aekong commented Jul 29, 2021

Oh @aekong should we include #31 in this PR too?

yeah!

* install shellcheck

* add scripts/prepublish-checks

* run prepublish checks in CI

* add lint-scripts and prepublishOnly npm scripts

* nix "wut.css" from prepublish checks
@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-35 July 29, 2021 23:30 Inactive
@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-35 July 29, 2021 23:39 Inactive
@shawnbot
Copy link
Member Author

@aekong I'd like to test the responsive button snippet from #34 with the release candidate before merging. 🤞

@shawnbot
Copy link
Member Author

Quick follow-up: I think this works pretty well!

<div class="border border-solid border-grey-2 rounded p-16 text-center">
  <span class="mx-4">Drop files to attach, or</span>
  <button class="
    btn btn-secondary btn-block mt-8
    lg:inline-flex lg:w-auto lg:mt-0
  ">Browse</button>
</div>

@shawnbot shawnbot merged commit 23c5d73 into main Jul 29, 2021
@shawnbot shawnbot deleted the release-1.3.0 branch July 29, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants