Merge shopify-cli-extensions into cli
#237
Conversation
dmhenry
requested review from
Fionoble,
pepicrft,
alfonso-noriega,
isaacroldan and
vividviolet
|
The CLA failures are due to @t6d & @rmshopify needing to sign the Contributor License Agreement. |
|
This looks good. |
|
@isaacroldan That makes sense. I don't mind going through the process again trying with that directory structure. With respect to the Contributor License Agreement, is that something we can disable for this effort? The two individuals tagged no longer work for Shopify, but I'm not sure if this is something we're allowed to sidestep, or quite how to do it. |
|
About the directory structure, that's something I need to discuss with the team. Won't happen this week but since it's going to implicate quite some changes, maybe it can be done after merge. About the CLA, I think we can force-merge, but i'll ask about it (there aren't are many options anyway) |
dmhenry
force-pushed
the
rewrite
branch
3 times, most recently
from
c4ceb90 to
d6bd2c4
Compare
…e compiled successfully - allows subscribers to be notified when assets by updating the asset urls when sending the update message - subscribers can use the updated urls instead of maintaining their own logic to increase a reload param
- added vanilla-extract - configured using vite instead of webpack - test setup
- updated typings
…e) and standalone - tests not working but is running - still missing liting - app not working but is running
- fixed unit tests
- Move metafields config to the top level - Allow merging shopifile.yml config - Remove unused code for skipping empty directories - Fix bug in create where it was unnecessarily merging template data for irrelevant template folders Previously we had a MergeTemplates task that merge data for the global template (package.json.tpl and shopifile.yml.tpl) as well as merge data for a specific extension template. The global files are at the root so this task was also merging data for irrelevant templates. The fix is to break this into 2 different tasks, 1 to merge global templates and another to merge templates specific to the extension
Add simple logic to retain comments in yaml files - currently comments are simply appended to the end of the YAML file. This needs to be improved so that the comments are preserved in original place
* Custom error message generation on rebuild * Remove file system watching in favor of consuming the build processes log messages * Support for grouping multiple lines of log output into a single message
Expose surface so consumers can select relevant extensions Ensure app data keys are in lower camel case to match websocket response
…ssing error handling
…ns and cleand up unused files
dmhenry
changed the title
shopify-cli-extensions into clishopify-cli-extensions into cli
This is a dry run merging the
shopify-cli-extensionsrepo intocli. All ofshopify-cli-extensionslives in an eponymous top-level directory. We may decide on another structure, but the merge does seem to have worked. It is based on the steps detailed here. History does appear to be intact.WHY are these changes introduced?
As
cliandshopify-cli-extensionsare tightly coupled and CLI 2.0 is deprecated, the decision was made to merge these two repos for ease of release.WHAT is this pull request doing?
This branch was created by:
clishopify-cli-extensionsrewritebranch based onshopify-cli-extensions/mainrewritebranch oncli/mainrewritebranch upstream (to draft this PR)