Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes cli migration cli kit history #1213

Closed
wants to merge 6,202 commits into from
Closed

Themes cli migration cli kit history #1213

wants to merge 6,202 commits into from

Conversation

alvaro-shopify
Copy link
Contributor

@alvaro-shopify alvaro-shopify commented Jan 25, 2023 •
edited
Loading

WHY are these changes introduced?

Follow-up: #1173

Included commits history from CLI2

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

vividviolet and others added 30 commits May 20, 2022 17:23
@vividviolet
Merge pull request #2341 from Shopify/shopify-extensions-update-v0.12.0
afea88e 
Update shopify-extensions to v0.12.0
@dphm
Merge pull request #2340 from Shopify/discounts/rm-old
50e77c2 
Remove old discounts EPs
@alvaro-shopify
#2346 - Error received when deploying to Herokuu
12aebb3
@alvaro-shopify
#2346 - Fixed Rubocop errors
2143831
@alvaro-shopify
#2346 - Fixed PR comments
3a8c413
@alvaro-shopify
Merge pull request #2347 from Shopify/bugfix/2346-error-deploying-to-…
533571e 
…heroku

Fix #2346 Heroku CLI installation for Apple silicon
@dmariassy
Switch to monorail-edge.shopifysvc.com endpoint
057e26f
@sandor-shopify
rename beacon to web_pixel
3dd8c65
@sandor-shopify
more renameing
0fb8097
@andrewhassan
Require App Bridge paths + populate them on script create
4327c07
@karreiro
Fix 'CHANGELOG.md' (#2357)
00a013f
@dmariassy
Merge pull request #2349 from Shopify/monorail-edge-shopifysvc
9035ed9 
Switch to monorail-edge.shopifysvc.com endpoint
@sandor-shopify
formatting
1a0271a
@jianghong
Allow shipping_methods and payment_customizations to pull rust script…
4332455 
… examples
@dependabot
Bump rack from 2.2.3 to 2.2.3.1
a525ebb 
Bumps [rack](https://github.com/rack/rack) from 2.2.3 to 2.2.3.1.
- [Release notes](https://github.com/rack/rack/releases)
- [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md)
- [Commits](rack/rack@2.2.3...2.2.3.1)

---
updated-dependencies:
- dependency-name: rack
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@jianghong
Merge pull request #2359 from Shopify/add-rust-support-for-some-apis
b3a27b9 
Allow shipping_methods and payment_customizations to pull rust script examples
@ulgut
Provide better DX when dealing with empty theme selection (#2352)
b5d601c
@ulgut
Add -t/--theme support to the theme serve command (#2336)
2ff0157
@gonzaloriestra
Merge pull request #2360 from Shopify/dependabot/bundler/rack-2.2.3.1
6aa2ea4 
Bump rack from 2.2.3 to 2.2.3.1
@gonzaloriestra
Packaging for release v2.18.0
b2bf136
@gonzaloriestra
Merge pull request #2362 from Shopify/release_2_18_0
411c332 
Packaging for release v2.18.0
@sandor-shopify
Merge pull request #2353 from Shopify/rename_beacon_to_web_pixel
d5b676c 
Rename beacon to web pixel
@sandor-shopify
allow_custom_valid_templates_on_creation
8b763fa
@sandor-shopify
Merge pull request #2321 from Shopify/set_beacon_extension_template_o…
0104bc9 
…ptions

Set web pixel extension template options
@andrewhassan
Merge pull request #2356 from Shopify/ah.app-bridge-paths
c369719 
Require App Bridge paths + populate them on script create
@dmhenry
Feature/detect outdated postpurchase subscription (#2355)
e6d7b38 
Feature/detect outdated postpurchase subscription
@mkevinosullivan
Adds support for git branches to git clone
40aa72c 
This support is needed in order to use cli_two branches in app templates
repositories for backwards compatibility.
@mkevinosullivan
Changes node app repo to shopify-app-template-node
276c655 
In preparation to launch new Node app template, the repo name is being
changed from `shopify-app-node` to `shopify-app-template-node`
@mkevinosullivan
Merge pull request #2376 from Shopify/kos/support_git_branches
6c570c2 
Adds support for git branches to git clone
@mkevinosullivan
(intentionally empty)
52e5469
dependabot bot and others added 23 commits December 8, 2022 04:38
@dependabot
Bump nokogiri from 1.13.9 to 1.13.10
707e000 
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.9 to 1.13.10.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.13.9...v1.13.10)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@gonzaloriestra
Merge pull request #2699 from Shopify/dependabot/bundler/nokogiri-1.1…
119e93c 
…3.10

Bump nokogiri from 1.13.9 to 1.13.10
@mgmanzella
Bump theme-check version to 1.12.1 (#2701)
229b195
@gonzaloriestra
Merge branch 'main' into enable-theme-passwords-dev
56e1f9f
@gonzaloriestra
Merge pull request #2681 from Shopify/enable-theme-passwords-dev
73693d7 
Enable Theme Access passwords for theme serve
@gonzaloriestra
Packaging for release v2.33.0
38a09c9
@gonzaloriestra
Merge pull request #2703 from Shopify/release_2_33_0
f54aaad 
Packaging for release v2.33.0
@gonzaloriestra
Add automated steps to releasing instructions
f57da9a
@gonzaloriestra
Merge pull request #2704 from Shopify/automated-release-steps
17c7081 
Update release instructions
Delete checksum after file deletion (#2706)
9c3adb1 
### WHY are these changes introduced?

Fixes #733

Files that get added and uploaded, then deleted (both local and remote), then added again, will not get uploaded again, because checksums are outdated.

### WHAT is this pull request doing?

When a file has been successfully deleted (both local and remote), checksum in checksum store is removed, so that the same file can be reuploaded again.
@alvaro-shopify
Packaging for release v2.33.1
d8cb925
@alvaro-shopify
Merge pull request #2710 from Shopify/release_2_33_1
ce4cfda 
Packaging for release v2.33.1
@veken1199
bump theme-check to 1.13.0
5a99426
@pepicrft
Merge pull request #2714 from Shopify/bump-theme-check-version
f32d3f7 
bump theme-check to 1.13.0
@alvaro-shopify
bump theme-check to 1.14.0
64e5712
@alvaro-shopify
Merge pull request #2715 from Shopify/bump-theme-check-version-to-1-14-0
b5bfcea 
bump theme-check to 1.14.0
@alvaro-shopify
Packaging for release v2.34.0
b8c2445
@alvaro-shopify
Merge pull request #2717 from Shopify/release_2_34_0
0967baa 
Packaging for release v2.34.0
@dependabot
Bump rack from 2.2.3.1 to 2.2.6.2
da71b23 
Bumps [rack](https://github.com/rack/rack) from 2.2.3.1 to 2.2.6.2.
- [Release notes](https://github.com/rack/rack/releases)
- [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md)
- [Commits](rack/rack@2.2.3.1...v2.2.6.2)

---
updated-dependencies:
- dependency-name: rack
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@gonzaloriestra
Merge pull request #2718 from Shopify/dependabot/bundler/rack-2.2.6.2
c900a80 
Bump rack from 2.2.3.1 to 2.2.6.2
@alvaro-shopify
Add 'packages/cli-kit/assets/cli-ruby/' from commit 'c900a801b4753383…
4789079 
…db02513bd7d5b507372b3661'

git-subtree-dir: packages/cli-kit/assets/cli-ruby
git-subtree-mainline: 67aa11e
git-subtree-split: c900a80
@alvaro-shopify
Integrate execution of embed CLI2 code depending on an env variable
bf1aab5
@alvaro-shopify
Integrate lint and test tasks in cli workflow
1360309
@github-actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "yarn changeset add" to track your changes and include them in the next release CHANGELOG.

@github-actions
Copy link
Contributor

Benchmark report

The following table contains a summary of the startup time for all commands.

Status Command Baseline (avg) Current (avg) Diff
🟢 app build 885.67 ms 886.33 ms 0.08 %
🟢 app deploy 1153.67 ms 1155 ms 0.12 %
🟢 app dev 1145.33 ms 1147.33 ms 0.17 %
🟢 app env pull 1054 ms 1067 ms 1.23 %
🟢 app env show 1055.33 ms 1065.33 ms 0.95 %
🟢 app generate extension 1108 ms 1114.33 ms 0.57 %
🟢 app generate schema 1083.67 ms 1087.33 ms 0.34 %
🟢 app info 1055 ms 1064.67 ms 0.92 %
🟢 app scaffold extension 1110.33 ms 1104.33 ms -0.54 %
🟢 app update-url 1036 ms 1035.67 ms -0.03 %
🟢 theme check 823.33 ms 833 ms 1.17 %
🟢 theme delete 1021.67 ms 1009 ms -1.24 %
🟢 theme dev 1004.33 ms 1019 ms 1.46 %
🟢 theme help-old 824.67 ms 822 ms -0.32 %
🟢 theme info 867.67 ms 873.33 ms 0.65 %
🟢 theme init 920 ms 937.67 ms 1.92 %
🟢 theme language-server 822.33 ms 828.67 ms 0.77 %
🟢 theme list 1015.33 ms 1020.33 ms 0.49 %
🟢 theme open 1024 ms 1016 ms -0.78 %
🟢 theme package 828.33 ms 828.33 ms 0 %
🟢 theme publish 1017 ms 1025.67 ms 0.85 %
🟢 theme pull 1004.33 ms 1007.67 ms 0.33 %
🟢 theme push 1003 ms 1004.33 ms 0.13 %
🟢 theme share 1012.33 ms 1016.33 ms 0.4 %
🟢 webhook trigger 1016 ms 1012 ms -0.39 %

@alvaro-shopify alvaro-shopify mentioned this pull request Jan 25, 2023
Merged
6 tasks
@dmhenry
Copy link
Contributor

dmhenry commented Jan 25, 2023

@alvaro-shopify, IIRC when I faced the CLA issue in migrating shopify-cli-extensions the solution was to perform a force merge. The underlying problem is that all contributors are required to sign a CLA, but some of those folks simply don't work for Shopify any more.

@alvaro-shopify
Copy link
Contributor Author

Finally, the commit history from the older repo should not be retained. Closed in favor of #1173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.